BetterCrewLink (Proximity Chat)

BetterCrewLink (Proximity Chat)

444k Downloads

[BUG REPORT] BetterCrewLink can't find my audio devices, but CrewLink can.

aryairani opened this issue ยท 19 comments

commented
CrewLink (tag: v.2.0.1) BetterCrewLink (tag: v.2.2.5)
CrewLink-audio BetterCrewLink-no-audio

Desktop (please complete the following information):
OS: Windows 10 Pro Insider Preview
Version: 2004
OS build: 21286.1000
System type: 64-bit operating system, ARM-based processor

commented

Very weird, there shouldn't be much difference for this between our version and original crewlink tbh.

Only thing I can think of at the moment is that this function is fucking up.

session.fromPartition('default').setPermissionRequestHandler((webContents, permission, callback) => {

If u uncomment that it might work

commented

Hmm, I didn't understand what to try โ€” isn't that already uncommented?

commented

I ment comment out so add // before the lines
256 until 268

commented

https://mirror.bettercrewl.ink/beta/Better-CrewLink%20Setup%202.2.0.exe
Can u check if u have the same issues with that version of bettercrewlink.

commented

I'm downloading it now. Do you think I'll run into the same 64-bit memory.js / ARM issue with that installer?

I did try commenting out 256โ€“268 and then yarn dev with no change.

commented

With that installer, it does detect my audio devices ๐ŸŽ‰ , but (like we previously talked about) doesn't detect Among Us.

commented

I'm still having this issue with the latest release. CrewLink 2.0.1 works fine, BetterCrewLink 2.3.5 can't detect my audio devices.

commented

Commenting out that block you suggested above doesn't help though.

commented

@OhMyGuus It seems to have been this commit that broke it for me 60fdff4.

commented

@OhMyGuus It seems to have been this commit that broke it for me 60fdff4.

That looks an interesting commit to bisect ... ๐Ÿ˜‚

commented

It's just the electron version update; v9.x worked; v10.x, 11.x, 12.x didn't. :-\

commented

I can create a PR to switch to electronjs 9.4.4, but since 9.x recently is EOL, I'm not sure it would or should be accepted. However, I wish the bug report could be submitted to electronjs by someone who knows enough about electronjs to do it. (i.e. not me)

commented

Gotcha, thanks for the insights, @aryairani . Agreed that fixing whatever issue presents in electron >= 10 is the way forward, alas I'm just as lost as you where this code is concerned! ๐Ÿ˜

commented

In the mean time though, I have to build BetterCrewLink from source with electron 9.4.4 to be able to run it :-\ Would be great if I didn't have to.

commented

With

Parallels Desktop Version 16.5.0 (50692)
Microsoft Windows 10 Pro v10.0.21376 (21376)

I don't have the issue anymore on v2.6.4 or even the original v2.2.5, so I'm closing the issue.

commented

Also, the 64-bit version seems to run for me now; no more yarn dist:32 or custom builds with auto-updates disabled. ๐ŸŽ‰ ๐Ÿคž

commented

Thanks for finding out that electron v9.x worked which means that it is an issue with newer versions of chromium on windows on arm. This is quite annoying since switching to a lower version will cause other errors as well I think (the cannot connect to microphone issue on some headsets).

commented

I can help with reproducing a minimized case on windows arm, for submitting as a ticket to electron or chromium or whatever, but am not knowledgeable enough to construct it myself. Feel free to ping me here or on Discord to coordinate.