Disconnecting right after earning science does not save your recently acquired science

Question

Disconnecting right after earning science does not save your recently acquired science

Xinayder opened this issue 10 years ago · 7 comments

Xinayder commented 10 years ago

This should be easy to fix. Check if the user earned some science, if he did, send an update message to the server.

sentryjs · Answer 1 · 2015-05-12T05:57:57.000Z

Would this fix it? I have no idea how to build this to test, sorry.

Xinayder · Answer 2 · 2015-05-12T23:38:26.000Z

A fix for this would be catching the onexit method, make it wait, send the progress scenario node and then quit. I have something working localy. I'll see if it works and solves this issue. This is also related to some crashes after force-closing KSP.

Xinayder · Answer 3 · 2015-05-12T23:39:25.000Z

By the way, the default scenario send time is 30 seconds.

sentryjs · Answer 4 · 2015-05-13T02:49:51.000Z

@RockyTV I saw the default send time also but I think it should stay 30 because otherwise
string scenarioHash = Common.CalculateSHA256Hash(scenarioBytes);
gets run more often. I figured it might cause more lag or work on cpu (though I have no idea how taxing it actually is).

oldmud0 · Answer 5 · 2015-05-12T22:15:23.000Z

@sentrythethird All you need to do is commit those changes into a new branch and make a pull request.

Xinayder · Answer 6 · 2015-05-29T00:16:32.000Z

Should be fixed as of 6192598.
If the issue persists, feel free to re-open this issue.

Closed #304.

madolinn · Answer 7 · 2015-04-29T07:47:12.000Z

Testing this, seems to be completely random how often progress is saved. Completed 4 research gains on one flight. Reconnected. Lost all progress.

Repeated, same gains, unlocked tech, reconnected. Lost all progress.

Repeated, launched another vessel, recovered. reconnect, lost all progress.

Repeated. Waited a little while, reconnected, saved.

Share to