Free IVA

Free IVA

106k Downloads

Passable fuel tanks incompability with part contents customisation mods.

Lucaspec72 opened this issue · 7 comments

commented

It seems that the B9PartSwitch Fatal error bug doesn't happen only with Configurable Containers, but any mod that allow modification of tanks contents (tested interstellarfuelswitch and b9stockpatch).
Considering this, is there any way of fixing this that doesn't involve completely disabling passable fuel tanks or tank customisation ? (perhaps have a option to always have passable iva ?)

Originally posted by @Lucaspec72 in #183 (comment)

commented

FreeIVA works correctly with Cryotanks and probably would have worked with b9stockpatch.

I’ll probably eventually address this issue (either provide structural variants or a passthrough-for-all option, or both) at some point, but it’s not very high on my priority list. I’ve also had several people say that they enjoy being forced to think about connectivity.

commented

KSP.log
attached is a log of trying to load b9stockpatches. (for some reason interstellarfuelswitch doesn't seem to show a fatal error when loading, but i'll display a error message when trying to place a part that should have passable iva.

commented

I'm not familiar with b9stockpatch, but FreeIva's configs are designed to work with mods that configure tank contents using b9ps - so there might be some unintended bug there.

I was nearly able to write a patch for ModularFuelTanks using b9ps to modify its fields, but it doesn't play nicely with b9ps because of its behavior in its OnLoad function. I'll have to take a look at IFS.

I think maybe the best solution would be to create structural variants of the parts when other options aren't available. I think it's also reasonable to have a "passthrough for all" type patch that enables traversal without altering the part's properties but I wouldn't want that to be default.

commented

yeah IFS doesn't play with b9ps either. I'll have to disable it.

commented

B9StockPatch is just broken - it throws that error even when FreeIva is not installed.

commented

oh right, should probably have checked that. what about interstellarfuelswitch ?

commented

do you think you'll implement this "passthrough for all" option ? i agree that not reducing the available volume when adding a iva tunnel is kinda cheaty, but it would allow compability with other mods modifying the contents of tanks until a better solution is found, as i doubt those mods are the only ones where this bug might occurs.