Kerbal Inventory System (KIS)

Kerbal Inventory System (KIS)

Mods
1M Downloads

Wrong size detection on the MH expansion parts

ihsoft opened this issue ยท 1 comments

commented

Some structural parts from MakindHistory expansion are not correctly handled in terms of size and attach points.

image

On the screenshot a regular T-12 part is attempted to be dragged out and deployed.

  1. The real scale of the model is not recognised.
  2. The attach node positions didn't match the part's declaration.
commented

Investigation result

The new "variants" feature allows setting different attach nodes and models (and may be some more stuff) for the same part in the editor. It's controlled via a new module ModulePartVariants. The stock parts (pre-DLC) use this module to set skins on the part, but in the MH DLC it's not unusual to see this functionality used to customize the size of the models (FYI @BobPalmer). It completely ruins the KIS approach of making the "preview models" when dragging a part.

What is feasible

If the part exists in the scene (i.e. it's "material"), there is a way to check which models are really used, so there is a fix.

What is not feasible

If the part is stored in a KIS container, then it's not material. The only way to deal with such a part is accessing its prefab. And in this case the model states vary from "everything is fine" to "no valid models at all". This breaks a lot of things in KIS and cannot be fixed in the short term. See a dedicated issue #273.