Arduino flight data

Question

Arduino flight data

EricKerman opened this issue 7 years ago · 8 comments

EricKerman commented 7 years ago

Anytime I pull flight data like altitude or g’s the game locks for about 1/2 second.

djungelorm · Answer 1 · 2018-04-10T07:05:23.000Z

Can you please provide some example code that demonstrates the issue?

EricKerman · Answer 2 · 2018-04-10T23:44:48.000Z

error = krpc_SpaceCenter_Flight_SurfaceAltitude(conn, &Altitude, flight); seems to be the line but here is the full IDE. Its a work in progress so its kinda messy. All the control calls work fine. #include <krpc.h> #include <krpc/services/krpc.h> #include <krpc/services/space_center.h> //define pins #define SAS_CONTROL_PIN 22 #define SAS_LIGHT_PIN 23 #define RCS_CONTROL_PIN 24 #define RCS_LIGHT_PIN 25 #define BREAKS_CONTROL_PIN 26 #define BREAKS_LIGHT_PIN 27 #define GEAR_CONTROL_PIN 28 // Gear over write control #define GEAR_LIGHT_PIN 29 #define WHEELS_CONTROL_PIN 30 #define WHEELS_LIGHT_PIN 31 #define INTAKES_CONTROL_PIN 32 #define INTAKES_LIGHT_PIN 33 #define PARACHUTES_CONTROL_PIN 34 #define PARACHUTES_LIGHT_PIN 35 #define CARGOBAYS_CONTROL_PIN 36 #define CARGOBAYS_LIGHT_PIN 37 #define RESHARVDEP_CONTROL_PIN 38 // ResourceHarvesters deployed #define RESHARVDEP_LIGHT_PIN 39 #define RESHARVACT_CONTROL_PIN 40 // ResourceHarvesters Active #define RESHARVACT_LIGHT_PIN 41 #define SOLAR_CONTROL_PIN 42 #define SOLAR_LIGHT_PIN 43 #define SASMODE_Control_PIN A15 // not sure it this is right. #define Speedmode_Control_PIN A13 void SetPins(){ pinMode(SAS_CONTROL_PIN, INPUT_PULLUP); //high to ground pinMode(RCS_CONTROL_PIN, INPUT_PULLUP); pinMode(BREAKS_CONTROL_PIN, INPUT_PULLUP); pinMode(GEAR_CONTROL_PIN, INPUT_PULLUP); pinMode(WHEELS_CONTROL_PIN, INPUT_PULLUP); pinMode(INTAKES_CONTROL_PIN, INPUT_PULLUP); pinMode(CARGOBAYS_CONTROL_PIN, INPUT_PULLUP); pinMode(RESHARVDEP_CONTROL_PIN, INPUT_PULLUP); pinMode(RESHARVACT_CONTROL_PIN, INPUT_PULLUP); pinMode(SOLAR_CONTROL_PIN, INPUT_PULLUP); } void SetLED(){ pinMode(SAS_LIGHT_PIN, OUTPUT); pinMode(RCS_LIGHT_PIN, OUTPUT); pinMode(BREAKS_LIGHT_PIN, OUTPUT); pinMode(GEAR_LIGHT_PIN, OUTPUT); pinMode(WHEELS_LIGHT_PIN, OUTPUT); pinMode(INTAKES_LIGHT_PIN, OUTPUT); pinMode(CARGOBAYS_LIGHT_PIN, OUTPUT); pinMode(RESHARVDEP_LIGHT_PIN, OUTPUT); pinMode(RESHARVACT_LIGHT_PIN, OUTPUT); pinMode(SOLAR_LIGHT_PIN, OUTPUT); } HardwareSerial * conn; krpc_SpaceCenter_Control_t instance; krpc_SpaceCenter_Vessel_t vessel; krpc_SpaceCenter_Control_t control; krpc_SpaceCenter_Flight_t flight; //Global Craft Flags bool previousStage = false; bool sas; bool rcs; bool gear; bool lights; bool breaks; bool antennas; bool cargobays; bool airintake; bool parachutes; int throttle; bool recoverable; double Altitude; float GForce; void blink_led(int count) { delay(200); for (int i = 0; i < count; i++) { digitalWrite(LED_BUILTIN, HIGH); delay(400); digitalWrite(LED_BUILTIN, LOW); delay(400); } delay(200); } krpc_error_t error; //keep Global //** Functions** //get SASstatus function void GetSAS(){ do { error = krpc_SpaceCenter_Control_SAS(conn, &sas, control); // krpc_error_tkrpc_SpaceCenter_Control_SAS(krpc_connection_t connection, bool * result) if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void GetGear(){ do { error = krpc_SpaceCenter_Control_Gear(conn, &gear, control); if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void GetLights(){ do { error = krpc_SpaceCenter_Control_Lights(conn, &lights, control); if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void GetBreaks(){ do { error = krpc_SpaceCenter_Control_Brakes(conn, &breaks, control); if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void GetAntennas(){ do { error = krpc_SpaceCenter_Control_Antennas(conn, &antennas, control); if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void GetCargoBays(){ do { error = krpc_SpaceCenter_Control_CargoBays(conn, &cargobays, control); if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void GetAirIntakes(){ do { error = krpc_SpaceCenter_Control_Intakes(conn, &airintake, control); if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void GetParachutes(){ do { error = krpc_SpaceCenter_Control_Parachutes(conn, &parachutes, control); if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void GetAltitude(){ do { error = krpc_SpaceCenter_Flight_SurfaceAltitude(conn, &Altitude, flight); //** right here** if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void GetGForce(){ do { error = krpc_SpaceCenter_Flight_GForce(conn, &GForce, flight); //** or here** if (error != KRPC_OK) { delay(50); } } while (error != KRPC_OK); } void setup() { pinMode(LED_BUILTIN, OUTPUT); digitalWrite(LED_BUILTIN, LOW); SetPins(); // pinMode(STAGE_PIN, INPUT_PULLUP); conn = &Serial; // Open the serial port connection do { // Open the serial port connection error = krpc_open(&conn, NULL); if (error != KRPC_OK) { delay(100); } } while (error != KRPC_OK); // Set up communication with the server do { error = krpc_connect(conn, "Main Controller Panel"); if (error != KRPC_OK) { blink_led(-(int) error); delay(100); } } while (error != KRPC_OK); do { error = krpc_SpaceCenter_ActiveVessel(conn, &vessel); if (error != KRPC_OK) { delay(100); } } while (error != KRPC_OK); do { error = krpc_SpaceCenter_Vessel_Control(conn, &control, vessel); if (error != KRPC_OK) { delay(100); } } while (error != KRPC_OK); } void loop() { bool gearSW = digitalRead(GEAR_CONTROL_PIN) == LOW; if (gearSW){ error = krpc_SpaceCenter_Flight_SurfaceAltitude(conn, &Altitude, flight); //Altitude =0; GetAltitude(); // ***this calls to the fuction above ***** if (Altitude < 100){ krpc_SpaceCenter_Control_set_Gear(conn, control, HIGH); //lowers the gear and locks }else { krpc_SpaceCenter_Control_set_Gear(conn, control, LOW); //raises the gear and locks } // else if the switch is off it does nothing } //GetSAS(); GetGForce(); // Display gear GetGear(); if (gear) { digitalWrite(LED_BUILTIN, HIGH); } else { digitalWrite(LED_BUILTIN, LOW); } delay(1000); } Sent: Tuesday, April 10, 2018 at 2:05 AM From: djungelorm <[email protected]> To: krpc/krpc <[email protected]> Cc: "Eric Kerman" <[email protected]>, Author <[email protected]> Subject: Re: [krpc/krpc] Arduino flight data (#458) Can you please provide some example code that demonstrates the issue? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

EricKerman · Answer 3 · 2018-04-11T22:20:13.000Z

Here is a Cleaner version. That has the issue after the rocket gets above 1000m and stops when it goes back below 1000m. It's weird because it gets called the same way, but if it's in a while loop its ok.

#include <krpc.h>
#include <krpc/services/krpc.h>
#include <krpc/services/space_center.h>

HardwareSerial * conn;

#ifdef KRPC_ERROR_CHECK_FN
#include <krpc/error.h>

// Error handler function called if an RPC fails
void error_handler(krpc_error_t err) {
while (true) {
for (int i = 0; i < -(int)err; i++) {
//digitalWrite(LED_BUILTIN, HIGH);
delay(200);
//digitalWrite(LED_BUILTIN, LOW);
delay(200);
}
delay(1200);
}
}
#endif

void setup() {

conn = &Serial; // Open the serial port connection
krpc_open(&conn, NULL);

}

void loop() {

prog();
delay(2);
}

void prog() {
krpc_connect(conn, "Sub-orbital flight");

krpc_SpaceCenter_Vessel_t vessel;
krpc_SpaceCenter_ActiveVessel(conn, &vessel);

krpc_SpaceCenter_AutoPilot_t auto_pilot;
krpc_SpaceCenter_Vessel_AutoPilot(conn, &auto_pilot, vessel);

krpc_SpaceCenter_AutoPilot_t control;
krpc_SpaceCenter_Vessel_Control(conn, &control, vessel);

krpc_SpaceCenter_AutoPilot_TargetPitchAndHeading(conn, auto_pilot, 90, 90);
krpc_SpaceCenter_AutoPilot_Engage(conn, auto_pilot);
krpc_SpaceCenter_Control_set_Throttle(conn, control, 1);
delay(1000);

krpc_SpaceCenter_Control_ActivateNextStage(conn, NULL, control);

krpc_SpaceCenter_Resources_t resources;
krpc_SpaceCenter_Vessel_Resources(conn, &resources, vessel);

krpc_SpaceCenter_Flight_t flight;
krpc_SpaceCenter_Vessel_Flight(conn, &flight, vessel, KRPC_NULL);
double mean_altitude;
while (true) {
krpc_SpaceCenter_Flight_MeanAltitude(conn, &mean_altitude, flight);
if (mean_altitude > 1000)
break;
}
krpc_SpaceCenter_Flight_MeanAltitude(conn, &mean_altitude, flight);
//krpc_SpaceCenter_Control_ActivateNextStage(conn, NULL, control);

}

djungelorm · Answer 4 · 2018-04-16T22:05:52.000Z

Been having a look at this and I can't quite figure out what this is wrong, and I don't quite follow what you mean by it having the issue above 1000m and fine again below 1000m?

Also I notice you repeatedly run prog from loop. Is this really the intended behaviour? Maybe make it so that prog only runs once to completion and then stops. For example:

bool ran = false;
void loop() {
    if (!ran)
        prog();
    ran = true;
}

In the first code you posted, you never write to the flight variable -- so its value could be anything. This would cause issues when trying to get flight data, and the server is probably returning an error when you do so. The waiting you see could just be the error detection loop in your code? Also worth checking the game's output log to see any possible errors the server is sending (just in case the error detection code isn't working as expected).

EricKerman · Answer 5 · 2018-04-17T20:42:39.000Z

Use the 2nd for the easier example. The call to prog() is the way I wanted it. This was built off a simple sounding rocket. It would detach the engine stage at 1K and also demonstrated the pause does not happen while in the loop. When I knew that worked I commented it out the staging deliberately and made it a call for altitude to demonstrate the pause is there every time it is called. So as soon as the craft gets to 1000 meters the bug pauses\delays\locks the game.

After the craft goes falls back to Kerbin below 1000 meters the program gets trapped back in the while loop and the bug goes away because the call is not being made repetitively.

There is nothing interesting in the LOG. I will try to post it soon.

Because the stream is not an option I want to call the flight data every loop or every other loop-ish, but if it pauses the game it unusable. Thanks for looking into this.

tilegg · Answer 6 · 2018-07-01T22:59:46.000Z

I'm pretty sure I have the same Issue: When requesting RCS and SAS status the server locks up the game for a few hundred ms. The game locks up when the rx-LED on the Arduino lits up and continues when the LED goes low. In the code example below the game locks up twice per cycle.

The logfile does not display anything out of the ordinary.

KSP: 1.4.3
Client: C-Nano, v0.4.5
Server: v0.4.6 (also tried 0.4.5, no difference)
Other installed mods: Also checked without any, no difference

Arduino sketch:

#include <krpc.h>
#include <krpc/services/krpc.h>
#include <krpc/services/space_center.h>

HardwareSerial * conn;
krpc_SpaceCenter_Vessel_t vessel;
krpc_SpaceCenter_Control_t control;

void setup() {
  pinMode(LED_BUILTIN, OUTPUT);
  digitalWrite(LED_BUILTIN, LOW);

  conn = &Serial;
  // Open the serial port connection
  krpc_open(&conn, NULL);
  // Set up communication with the server
  krpc_connect(conn, "Arduino Example");

  // Indicate succesful connection by lighting the on-board LED
  digitalWrite(LED_BUILTIN, HIGH);

  krpc_SpaceCenter_ActiveVessel(conn, &vessel);
  krpc_SpaceCenter_Vessel_Control(conn, &control, vessel);
}

void loop() {
  boolean rcs;
  boolean sas;
  
  krpc_SpaceCenter_Control_RCS(conn, &rcs, control);
  krpc_SpaceCenter_Control_SAS(conn, &sas, control);
  
  delay(1000);
}

kRPC Settings:

Screenshot during lockup (Exec time goes down to .01 after the lockup and then up again):

djungelorm · Answer 7 · 2018-07-22T15:57:12.000Z

Sorry I've been a bit busy recently and didn't have time to follow up on this.

Thanks for the nice simple test case. Unfortunately I don't see the same behaviour on my system, running under Linux. Are you on Windows?

The kRPC server is implement as a single thread that runs whenever the game updates, and this relies on RPCs executing reasonably fast. My guess is that the serial communication is taking a longer time than it should, for whatever reason, which would cause this behaviour.

tilegg · Answer 8 · 2018-07-26T10:14:23.000Z

Yep, I'm on Win10.

Share to