kRPC: Control the game using C#, C++, Java, Lua, Python...

kRPC: Control the game using C#, C++, Java, Lua, Python...

7.8k Downloads

Some unit tests are flaky

djungelorm opened this issue ยท 3 comments

commented

Some of the unit tests (specifically event tests for clients that test an event takes a certain amount of time) are quite flaky when running the tests in parallel.

Maybe mark them as flaky so they repeat if they fail up to a certain number of times?

commented

I have also observed the java krpc.client.EventTest test failing in CI (which doesn't run in parallel). These event tests are flaky as they test how long the event takes (in seconds). We could either increase the tolerance on the time measurements, or retry the test a few times until it passes.

commented

Related to #629

commented

LIst of flaky tests:

  • Java client:
    • krpc.client.EventTest
  • Python client:
    • krpc.test.test_event.TestEvent.test_event_calback
    • krpc.test.test_event.TestEvent.test_event_remove_callback