KSPIE drills extremely slow
alismatales opened this issue · 8 comments
I tracked this issue down to this code:
KSP-Interstellar-Extended/FNPlugin/Collectors/UniversalCrustExtractor.cs
Lines 596 to 597 in 7b22a5d
(As well as further above in 585 and 586)
"abundance" is a decimal percentage (and therefore never larger than 1), and exponentiating that with the power of 4 makes it extremely small.
I dont quite understand what this bit of code was supposed to do, but i believe it can simply be removed, that gives the universal drill the same mining speed as a stock drill.
Nope this is intentional, it is a way to create very low densities functional because the stock resource system does not allow densities below 0.001, which is not low enough
see alsi
but I should probably replace the four by a 3
The general idea is to make trace amount of rare resource available to such low density that make it not very worthwhile. For example Uranium is technically everywhere in the ground, it just in such low densities that you would be crazy to mine it.
No offense, but do you even play KSP with your own mod?
if (abundance < 1)
does not make sense in this context since abundance is a decimal percentage - it is always less than one - a abundance of, say, 4,3% is reported as 0,043 - exponentiate that to the power of 4 and you get a value of 0,000000341.
The universal drill then takes that 0,000000341 and calculates the mined amount which is ridiculously low even for relatively high abundances.
The stock drill is thousands of times faster than the universal drill in the current state.
I understand what you are trying to do but the currecnt execution doesnt work properly.
Always less than 1? I was under the impression it could go up to 100, meaning 100%, that also how they are defined.
I guess what you meant to write is
if (abundance < 0.01)
in words "if the abundance is less than 1%"
lol, my own code at FNMassSpectrometer appears to confirm what your say, because I multiply it by 100 to convert it to a percentage. Good find!!