Xenon craft delta v
holmesmi opened this issue · 10 comments
MechJeb Version
2.81
KSP Version
1.61
Description
I'm flying my ship, which is down to Zenon fuel and the Dawn engine. The MechJeb delta V window is showing that I've got nothing, but I clearly do.
Replication Case
KSP.log
This seems to happen with every Zenon craft I have, so replication shouldn't be a problem. I'm assuming you don't need logs, but if you do, let me know, and I'll grab some.
Just replying to say that I have seen your issue. I just need some quiet time to look into it...
Yeah I validated in the VAB and on the pad and with available eC, both on 1.5.x
I'm guessing I broke something in FuelFlowSimulation, but nothing seems obvious to me.
I think it is when you refactored this c3abe3a#diff-dc9768afe4b434960c417797ed67938aL655
I do not find the check for ResourceDensity > 0 anywhere. I guess the easiest fix would be to add any propellant with a density of 0 to the freeResources list ?
Fix pushed from my lunch break without a compiler around. Followed by a reminder that MJ is not coded in python ( 43fb12f )
Try dev build 867 ( https://ksp.sarbian.com/jenkins/job/MechJeb2-Dev/867/ )
right that just came up the other day on the RO discord that batteries have a wet mass and dry mass for the batteries, but zero resource density, or something crazy like that.
not working for me unless i did something equally dumb like forget to make install again... which it looks like i did not do...
i'll try to take a look at it later now that i have a good hint...
868 ought to fix this: https://ksp.sarbian.com/jenkins/job/MechJeb2-Dev/868/
@sarbian You want to do a patch release of the code as it is now? It seems like this fix for Xenon ∆v and the fix for launch-to-plane might warrant it. I've got some major changes that I'm thinking about shipping which would risk more destabilization and it feels like this might be a fairly happy point right now. No rush tho.
@lamont-granquist Yes, we should do a release.