[Bug 🐞]: FAR Parachute Incapability Due to Wrong MM Config
T2Fat2Fly opened this issue · 0 comments
Brief description of your issue (aka the problem)
With Ferram Aerospace Research Continued installed, OhScrap parachute failure module doesn't apply correctly, which appears to be an MM config issue.
Operating system
No response
KSP version
1.12.3.3173
Version of addon
2.2.1.0-beta
Steps to reproduce the behavior or issue
- Install FARc. ScrapYard & OhScrap
- Start/load a game and go to VAB
- Place a parachute part onto the vessel
- Right-click the parachute part
Expected behavior
"Parachute Safety Rating" entry should appear in the PAW, indicates that OhScarp is monitoring the part.
Actual behavior
"Parachute Safety Rating" entry is missing.
Environment
KSP 1.12.3
ScrapYard 2.2.2.1-release
OhScrap 2.2.1.0-beta
Ferram Aerospace Research Continued 0.16.1.1
I don't think logs are required for this issue. Please see below for more information and a possible fix.
Log files
No response
Screenshots
No response
Additional context
From ParachuteFailureModule.cfg, ParachuteFailureModule
and FARParachuteFailureModule
are applied to parts with @MODULE[ModuleParachute]
:
@PART[*]:HAS[@MODULE[ModuleParachute]]:NEEDS[OhScrap,ScrapYard]:FOR[OhScrap]
However as of FARc 0.16.1.1, parachutes are patched to have MODULE[RealChuteFAR]
instead. For example, the MK16 Parachute from the config cache: [...] Re-referencing to the FARc cfg for better precision.
From the RealChuteLite.cfg:
[...]
//If RealChute isn't installed, run on every part
@PART[*]:HAS[@MODULE[ModuleParachute]]:NEEDS[!RealChute]:FOR[FerramAerospaceResearch]
{
//Transform ModuleParachute into RealChute (removing ModuleParachute)
@MODULE[ModuleParachute]
{
@name = RealChuteFAR
}
[...]
}
A simple fix to the MM config patch file should solve the issue. I'm filling a PR for the fix. PR submitted as #77.
The same parachute part after the fix:
How did you download and install this?
CurseForge (download and manual installation)