SDHI Service Module System

SDHI Service Module System

60.7k Downloads

Use of :FINAL in MM patches

RedAV8R opened this issue ยท 4 comments

commented

Not sure if it's intended or not, but the use of :FINAL in your MM patches is hard for others to modify things. I do understand the want to prevent others from doing so and the troubleshooting involved. If I submit a PR to replace them would you be receptive to that?

The TACLS patch is outdated as well.

commented

Not sure if it's intended or not, but the use of :FINAL in your MM patches is hard for others to modify things. I do understand the want to prevent others from doing so and the troubleshooting involved. If I submit a PR to replace them would you be receptive to that?

Some of the instances are deliberately meant to be final (e.g. the patch that adds the umbilical model to the pod, the life support patches).

I can definitely consider PRs on a case-by-case basis, but you'll need to justify each and every modification.

The TACLS patch is outdated as well.

Has the current maintainer changed things around yet again?

Might be good to post this as a separate issue.

commented

#119 There you go. Sorry about the wait.

commented

@RedAV8R, I am waiting on your pull requests.

commented

As per discussions in #119, PR accepted and merged with thanks!