Sigma Binary

Sigma Binary

753 Downloads

Strange Blue Dot

FractalCyclone opened this issue ยท 10 comments

commented

Blue Dot from Sigma Binary / Distant Object Enhancement conflict.

Spawns from craft, single-sided texture invisible when viewed from any other direction. Not collidable, static once spawned.

The issue only presents itself when there is a binary system loaded and Distant Object Enhancement is installed.

screenshot2
screenshot0

KSP 1.7.3
Kopernicus - 1.7.3.2
ModularFlightIntegrator - 1.2.6.0
Sigma Binary - 1.7.2
Distant Object Enhancement - 1.9.1.1
SigmaDunaIke

KSP.log

commented

After looking at this issue I would say that most likely the dot is added by DOE

The issue might show up only on SB because my mod adds very tiny bodies, I am not sure how DOE works tho, it might be helpful to get @MOARdV opinion on this

commented

I would also like to post this video that might give a better idea of the bug compared to screenshots

https://www.youtube.com/watch?v=uXpxmd7ZNNo

commented

Some notes from after I responded to your (Sigma88)'s PM on the KSP forum:

Based on the NRE in the log and the presence of a body flare on-screen, it is most likely in the second foreach loop in FlareDraw::GenerateBodyFlares ( https://github.com/MOARdV/DistantObject/blob/6a6c58bd6da882e0d52f38305f0b6584c80c6bbb/Source-Code/FlareDraw.cs#L283-L331 ).

I'm not sure what in that code would be coming up null, but I'm also not familiar with what's going on under the hood in Sigma Binary. As I mentioned in the DOE issue, I don't have the time to maintain DOE, so I'm not going to be able to resolve the issue any time soon.

commented

@MOARdV do you mind if I try to fix the issue and send you a PR? I think I might have an idea on how to approach this

commented

@FractalCyclone would you mind testing this ALPHA version of DOE and let me know if it works fine?
DistantObject_1.9.1.1_ALPHA.zip

thanks!

commented

that's weird, I didn't get the NullRef you are getting

I wonder if I included the wrong dll in the archive, let me check again

commented

yeah, it seems the wrong dll got included in the archive -.-

sorry

here's the fixed dll
DistantObject_1.9.1.1_ALPHA2.zip

commented

@Sigma88

I tried the alpha version of DOE with the same set of mods as before and it still resulted in the blue circle.

Sorry for the late response, work kick'd my butt last couple days.

KSP 1.7.3
Kopernicus - 1.7.3.2
ModularFlightIntegrator - 1.2.6.0
Sigma Binary - 1.7.2
Distant Object Enhancement - 1.9.1.1_ALPHA
SigmaDunaIke

screenshot10

KSP.log

commented

as soon as I get the OK from you I will release DOE 1.9.1.2

commented

I decided to go ahead and release the fix here:
https://github.com/Sigma88/DistantObject/releases

if you have other issues please open them here:
https://github.com/Sigma88/DistantObject/issues