Sigma Dimensions

Sigma Dimensions

1.4k Downloads

PQSCity2 Issues

DerpyFirework opened this issue ยท 10 comments

commented

A few weeks ago I mentioned a problem I was having with PQSCity2 and SigmaDimensions, and felt like posting it here as well, so you can keep track of it. I hope you don't mind.

The issue is with PQSCity2 (And possibly PQSCity) objects with snapToSurface set to false, and this results in them being repositioned several hundred kilometers above their intended position by SigmaDimensions.
(ie 600km above the intended point at 2x scale)

I believe the code in question starts at line 108 in SigmaDimensions.cs and appears to set the alt value of the PQSCity2 to account for the planet being rescaled, but it would seem PQSCity2 accounts for it already.

If you need any more information, I'll be happy to provide it.

edit: Just tested without the .dll, and everything's in the right place (other than KSC), and the planet is still scaled up.

I think treating pqsCity2.alt the same way as pqsCity2.snapHeightOffset might fix it, but then again, I know almost nothing about this.

commented

I'm a bit busy lately so I haven't had time to check on it yet, thanks for opening an issue, it will help me keep track of this stuff

commented

could you please give me a link to download your mod? so that I can test my dll against non-stock PQSCity2 mods?

thanks

commented

https://github.com/DerpyFirework/KSP-Structures
The GameData folder contains the compiled DLL and there is an example.cfg with an example object, however the example object is not affected by the bug I described above.

Thanks for looking into this!

commented

no problem :)
if you already have an object that gets the issue could you send me the cfg required?

here or on the forums, whatever you prefere

commented

Here's a config that places the example.cfg in the water next to KSC, will get the issue when used with a SigmaDimensions configs with resize anything but 1
example.txt

commented

perfect thanks! I'll take a look tonight

commented

I've fixed this issue, I forgot to compile the dll but I should be able to upload a test version here tonight

the fix has already been pushed to the development branch, so if you know how to compile it yourself feel free to test it

I suggest using this version since the later changes haven't been tested yet

commented

no problem!

happy it worked :)

commented

I'm going to close this issue, feel free to reopen it if you feel like there are still issues
(or make new ones for new issues)

commented

Managed to compile it, and the fix works perfectly! Thank you for looking into this.