FAR incompatibility
shadowmage45 opened this issue ยท 7 comments
Appears that FAR is still caching things instead of copying, or is somehow getting null meshes in some other manner.
Updating Amur 1 200
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 64)
Voxelization Time (ms): 166
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 64)
Std dev for smoothing: 3 voxel total vol: 0.156250002328306 filled vol: 0.0722184621118944
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 64)
deleting part SSTU-SC-ENG-J-2
(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 64)
NullReferenceException: Object reference not set to an instance of an object
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.GetVisibleMeshData (UnityEngine.Transform t, Boolean onlyMeshes) [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.CreateMeshListFromTransforms (System.Collections.Generic.List`1& meshTransforms) [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.RebuildAllMeshData () [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.GeometryPartModuleRebuildMeshData () [0x00000] in <filename unknown>:0
UnityEngine.Component:SendMessage(String, Object, SendMessageOptions)
UnityEngine.Component:SendMessage(String)
SSTUTools.SSTUModInterop:onPartGeometryUpdate(Part, Boolean)
SSTUTools.SSTUNodeFairing:buildFairing()
SSTUTools.SSTUNodeFairing:initialize()
SSTUTools.SSTUNodeFairing:OnStart(StartState)
Part:ModulesOnStart()
<Start>c__Iterator25:MoveNext()
(Filename: Line: -1)
NullReferenceException: Object reference not set to an instance of an object
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.GetVisibleMeshData (UnityEngine.Transform t, Boolean onlyMeshes) [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.CreateMeshListFromTransforms (System.Collections.Generic.List`1& meshTransforms) [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.RebuildAllMeshData () [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.FixedUpdate () [0x00000] in <filename unknown>:0
(Filename: Line: -1)
NullReferenceException: Object reference not set to an instance of an object
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.GetVisibleMeshData (UnityEngine.Transform t, Boolean onlyMeshes) [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.CreateMeshListFromTransforms (System.Collections.Generic.List`1& meshTransforms) [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.RebuildAllMeshData () [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.FixedUpdate () [0x00000] in <filename unknown>:0
(Filename: Line: -1)
NullReferenceException: Object reference not set to an instance of an object
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.GetVisibleMeshData (UnityEngine.Transform t, Boolean onlyMeshes) [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.CreateMeshListFromTransforms (System.Collections.Generic.List`1& meshTransforms) [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.RebuildAllMeshData () [0x00000] in <filename unknown>:0
at FerramAerospaceResearch.FARPartGeometry.GeometryPartModule.FixedUpdate () [0x00000] in <filename unknown>:0
(Filename: Line: -1)
Can confirm the exceptions, currently NO engine is working after using the Layout options as FAR can't revoxelize it.
I'd say mark FAR as incompatible for the time being as this can get pretty heavy NRE spam in multiple SSTU engine crafts.
Yep; sadly the fix has to come from FAR this time. Haven't even had any comments on the issue/ticket that I opened, so unsure if there are plans to fix it or not.
-Hopefully- I'll have time to submit a proper PR sometime this week/end.
PR has been submitted, now just need to wait for it to be accepted, merged, and an updated FAR released.
Are there any news on this one? Or is it most likely ferram will inlcude your PR in the update for 1.2 at this point I wonder.
ferram4 hasn't made any updates to FAR since before the PR was submitted. I'm sure it will be looked at at some point.
Fixed in FAR / PR has been merged. Should not be any problems with this in the next release of FAR + SSTU.
Have filed bug-report with FAR; will investigate more / submit a PR when I get back into town.