Telemachus

Telemachus

14.7k Downloads

Error in subscribing to subset of docking plotables

SavinaRoja opened this issue ยท 3 comments

commented

I am using the websocket api to Telemachus and discovered a potential bug in the handling of docking plotables: dock.ax, dock.ay, dock.az.

It might be related to this issue: #24

The version of Telemachus I am using might not contain the changes made to fix this; I will look into trying out the latest version. In any case I thought I would weigh in with my observations and testing with the websocket api.

If the target is set to an object with no docking ports (such as Minmus), then subscribing to any of these docking plotables results in the server dropping the connection. If the target is set to an object with docking ports at an unloaded distance, then the server drops the connection. At a loaded distance, if the target is set to the object with docking ports, but not a docking port itself, then the connection is dropped. If the target is set to a docking port itself, then the connection is maintained and subscription to these docking plotable variables works.

To be clear, these values are rather meaningless outside the context of a targeted docking port. So it is not a bug that these values are not available, but rather than subscribing to them results in an unhandled error that drops the connection.

If I find that the most up-to-date version of Telemachus resolves this issue, then I will report back and close the issue. On a related note, I will need to install Visual Studio and learn how to kajigger it to build Telemachus before I can test, might be a few days before I get that time.

commented

Some tips on building:

I found that the freely downloadable Visual C# 2010 install from Microsoft's site was sufficient to test on my Vista machine. It was able to open the .csproj files but not the .sln file; however, the .sln doesn't contain anything critical; you can build a brand-new one that contains the four .csproj files and everything will basically work for building purposes.

My testing flow was directly in KSP running my own builds of Telemachus (i.e. build, copy the build into the KSP directory, restart KSP). I didn't really get the unit tests to run successfully as far as I can tell. The text log file that KSP outputs while running has more information than shows up in the in-game debug console.

The issue you are seeing SHOULD be fixed by the latest version, but setting up the framework to build your own test versions is still a good exercise. :)

commented

I use Visual Studio Express 2012 so maybe the .sln file doesn't work for 2010.

The issue you are seeing SHOULD be fixed by the latest version,

I agree, but I haven't actually tested it.

commented

@fixermark

You will definitely make your life easier by using Visual Studio Express. The Telemachus project opens and runs without a glitch using it.