Only save settings in scenes that it makes sense to save the settings.
ntwest opened this issue ยท 0 comments
Hey @westamastaflash, love your mod!
But I found out it has a minor conflict with some enhancements @boop made to @linuxgurugamer's super-helpful EditorExtensionsRedux mod.
Recent versions of EER temporarily unbind the symmetry (X) and angle snap (C) hotkeys while in the Editor, in order to take over their handling and prevent the game from performing its default actions (which were previously in a bit of a race-condition with the mod's handlers and causing flakey-feeling behavior / timing issues).
It restores them when the scene is exited.
However, it seems your mod is triggering a call to GameSettings.SaveSettings while in the Editor. That's saving the unbound settings, which causes some grief if the game crashes or is killed before the user leaves the VAB/SPH.
Any chance you could avoid triggering that when in the VAB/SPH? Since TimeControl's knobs and levers aren't available in that scene, and AFAIK the user can't adjust time delta in it, I'm hoping this is an easy tweak for you. It would sure help us out.
I noticed you don't have a KSP 1.2-compatible release of TimeControl yet; let me know if you need help setting up an EER containing these modifications under KSP 1.1.3 (you need EER 3.2.14 and my DLL that backports Boop's fixes). Or alternatively I'd be happy to test for you.
More details (including the chunk of code we're asking you to modify) are described here: