Update Scale_Redist Version to 1.2

Question

Update Scale_Redist Version to 1.2

Lisias opened this issue 2 years ago · 4 comments

Lisias commented 2 years ago

Reasoning:

Some internal interfaces should be made public, otherwise 3rd Parties would never have full support from TweakScale for some borderline situations.

Lisias · Answer 1 · 2023-01-24T19:15:22.000Z

Implemented by 9c8e631

Lisias · Answer 2 · 2023-01-24T21:05:19.000Z

The last implementation wasn't enough.

Code was reworked on commit 36d7035

Lisias · Answer 3 · 2023-01-26T02:38:25.000Z

V2.5 was too much. Bumping the Major Number would imply that people would need to recompile the World against the new DLL, what's wrong.

There're new things on Scale_Redist, but the ones that were always there didn't changed a bit - so there's no need to recompile anything, and so bumping the Major is unnecessary.

Bumping it to 1.2 instead, since I had already bumped it to 1.1 when I implemented a Interface for 3rd Parties Sanity Checks.

Lisias · Answer 4 · 2023-01-27T02:56:56.000Z

I fired KSP 1.12.5 with TweakScale 2.4.6.20 but replaced the Scale_Redist with the 1.2 one to see how the thing will behave in the wild.

Then I shoved some Companions too, as they are still compiled against Scale_Redist 1.0 .

Scale_Redist v1.2.0.0 / v2.5.0.50
<…>
[LOG 23:46:25.252] [TweakScale] Version 2.4.6.20 /L
[LOG 23:47:44.436] [TweakScale] Support for KSP 1.9.0 to 1.12.5 Version 2.4.6.20 /L
[LOG 23:47:44.649] [TweakScaleCompanion.FS] Version 1.1.0.0 /L
[LOG 23:47:47.730] [TweakScaleCompanion.Frameworks] Version 0.3.0.0 /L BETA
[LOG 23:47:47.731] [TweakScaleCompanion.KIS] Version 1.0.0.1 /L
[LOG 23:47:47.733] [TweakScaleCompanion.PKMC] Version 2.1.0.0 /L
[LOG 23:52:42.611] [TweakScale] INFO: WriteDryCost: Started
[LOG 23:52:42.613] [TweakScaleCompanion.FS] INFO: SanityCheck: Started
[LOG 23:52:42.614] [TweakScaleCompanion.Frameworks] INFO: SanityCheck: Started
[LOG 23:52:42.616] [TweakScaleCompanion.KIS] INFO: SanityCheck: Started
[LOG 23:52:43.190] [TweakScale] INFO: WriteDryCost Concluded : 634 parts found ; 0 checks failed ; 0 parts with hotfixes ; 0 parts with issues overruled ; 0 Show Stoppers found; 0 Sanity Check failed; 93 unscalable parts.
[LOG 23:52:43.191] [TweakScaleCompanion.FS] INFO: SanityCheck Concluded : 634 parts found ; 6 parts using FSbuoyancy ; 0 show stoppers detected .
[LOG 23:52:43.191] [TweakScaleCompanion.Frameworks] INFO: SanityCheck Concluded : 634 parts found ; 0 parts using ModuleWaterfallFX ; 0 show stoppers detected .

No problems detected, it will be safe to deploy Scale_Redist 1.2 on an environment where most DLLs were compiled against 1.0.

So I'm closing this.

Share to