TweakScale

TweakScale

1M Downloads

New screw up from KSP 1.11.0 Editor was revealed by the 2.4.6.20 release

Lisias opened this issue · 8 comments

commented

When scaling radially attached parts with resources, from KSP 1.11.x (tested from 1.11.2 only) only the part that received the scaling have the resources scaled accordingly.

The clones retain the last Resource set.

This is not related to KSP-Recall, as on KSP 1.10.2 the problem didn't manifested itself.

See this and this post on Forum for the gory details.

commented

Recent fixes suggests that I should revisit this issue ASAP. It may be fixed by collateral effect by now.

commented

This is so frustrating. The problem just vanished in thin air, I couldn't reproduce this problem even on KSP 1.11.2, where I initially diagnosed it.

So I'm closing this.

commented

There's a possible explanation about the thing blowing up only after the refactoring: Monkey Patching.

On AirplanePlus I detected that KSP is able to Monkey Patch 3rd parties add'ons (bad, really bad move). Full history on Forum.

So we know for sure that KSP does Monkey Patching on 3rd parties Add'Ons without warning neither a way to turn it off.

So I'm guessing (and this is a wild guess, I admit) that perhaps on KSP 1.11.x they Monkey Patched TweakScale. And then, when I refactored it to get rid of that crappy escuse of bytes I was calling code, the Monkey Patching failed and exposed the problem inherent to KSP 1.11x and newer.

Still wondering what to do about.

commented

While closing #282 , I detected that on KSP >= 1.11.x the Auto Scale started to behave somewhat like this one.

I'm reasonably sure that Editor, from 1.11.x, screwed this.part.symmetryCounterparts somehow.

commented

Oukey… Things are getting hairy…

  1. You need to escale a "cloned" part in order to the thing misbehave. If you scale the "original", things works fine. It's a small detail that I forgot, and spent some time wondering why I wasn't reproducing the problem.

  2. If you open the PAWs, everything just works no matter what part you scale!

screenshot31

  1. If you close the PAWs, then the misbehaviour happens again!
commented

Loading and saving the Craft "fixes" the problem, as TweakScale recalculates everything on Loading.

Launching the thing also works, at least with Stock parts.

commented

This is pretty annoying, but not a killer bug - saving and loading, or just launching the thing worked for me as a work around.

So I will postpone this one and priorize Companion's new features.

commented

Aaaaaannddd…. THE FUCKING PROBLEM VANISHED OUT OF THE BLUE.

Just this, the problem suddenly is no more. Don't know how, don't know why.

The only difference from the last time I tried it is that this time I did it on my Acceptance Test Bed based on KSP 1.12.5 and with everything I officially maintain updated, in special https://github.com/net-lisias-ksp/KSPe , https://github.com/net-lisias-ksp/ModuleManager and https://github.com/net-lisias-ksp/ModuleManagerWatchDog and https://github.com/net-lisias-ksp/KSP-Recall .

Now… Why completely unrelated changes (probably on Recall?) "fixed" this problem is, frankly, a complete mystery for me at this time (besides I have some suspicions about the reason).