Auto-Scale is screwed since 2.4.7.0
Lisias opened this issue · 6 comments
Oukey, another one of that 🤦 moments.
When I worked on net-lisias-ksp/KSP-Recall#61 , I found a possible situation where TweakScale could be screwing up the current KSP lifecycle.
So I did this commit: feb5844
However, some idiot I don't know who I am decided to do a fucking typo on the parenthesis, and instead of typing [edit: I'm an idiot, but the idiocy is other thing - see next post](!(HighLogic.LoadedSceneIsEditor && this.IsScaled)), decided it would be a "better idea"™ to type (!HighLogic.LoadedSceneIsEditor && this.IsScaled) what's completely screwed up the OnEditorShipModified KSP callback.
I fired the priest and I'm suing him for the money back. Some competent Priest around? We are hiring.
Humm.... Stilll.... something doesn't fits. Double checking the "solution" didn't consistently fixed the problem. I must had messed up something, trying again.
Oukey, really found it now. My first sad excuse of a diagnose was poisoned by confirmation bias - I had made a similar idiocy on DayJob© last week, and it screwed up my current one.
But the root cause was correct - I really shouldn't had short-circuited that callbacks the way I did - yeah, it prevented a hypothetical problem I detected while diagnosing something else on KSP-Recall, but I created another problem without being aware.
"Fix is pretty obvious." ©2018 Elon Musk
I will postpone the release to tomorrow's lunch, or even evening. I should be on bed by now, not trying to publish releases risking mistakes due being tired. :/