TweakScale

TweakScale

1M Downloads

Variant parts are being wrongly displaced after changing the variant when scaled

Lisias opened this issue ยท 4 comments

commented

As the tittle says

Screen Shot 2024-05-04 at 08 44 11

I created this when refactored the beta branch. I lost the sweet spot as it appears.

This is to formalize the problem and so a proper documentation for it.

commented

I'm starting to get a glimpse on what I screwed when I refactored the beta branch. :)

~~ See 4923357 ~~


Nope. That commit made things worst - solved part of the problem, and created another one even worst.

Oukey, at least I now havea good insight about the problem.

commented

Not that I'm surprised, but this problem was not caused exactly by the refactoring, it just exposed it.

There's something on Editor screwing up things for TweakScale at the same time TweakScale is applying changes - almost surely this is happening on another Thread, because a co-routine running at the same thread would not be able to get in the middle of the process.

Skipping two frames using a wait co-routine did the trick. I should had though of this before.

Commit bfe2ec4 fixed this one.

commented

On a side note, the beta branch is now unlocked and can be pushed into the mainstream! THIS was the showstopper screwing up me.

commented

For some reason, this issue regressed on KSP 1.4.x on the Legacy branch.

KSP 1.5.0 and forward are OK at this moment.

The Beta branch is OK for 1.4.3