Skull causes chunk corruption
tvestok opened this issue ยท 10 comments
Advanced portals doesn't effect world saving. Do you mean if it's broken or something happens to it while under the influence of the plugin?
What we're seeing is the server crash. Advanced-Portals is always in the stack trace and it has something to do with loading chunks with skulls in them. If we remove Advanced-Portals, we can visit the chunk without a crash. When we remove the skulls, we can reinstall Advanced-Portals and safely visit the chunk.
That all being said.. we have also seen that some skulls do not make the server crash.
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR ------------------------------
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR Current Thread: Server thread
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR PID: 30 | Suspended: false | Native: false | State: TIMED_WAITING
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR Stack:
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR sun.misc.Unsafe.park(Native Method)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.IAsyncTaskHandler.awaitTasks(SourceFile:125)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:93)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.IChunkProvider.a(SourceFile:26)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.GeneratorAccess.isChunkLoaded(SourceFile:60)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.IWorldReader.isLoaded(SourceFile:272)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.World.updateAdjacentComparators(World.java:1331)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntity.update(TileEntity.java:120)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntitySkull$2.apply(TileEntitySkull.java:166)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntitySkull$2.apply(TileEntitySkull.java:1)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntitySkull.b(TileEntitySkull.java:177)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntitySkull.d(TileEntitySkull.java:161)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntitySkull.setGameProfile(TileEntitySkull.java:155)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntitySkull.load(TileEntitySkull.java:116)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntity.lambda$1(TileEntity.java:103)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntity$$Lambda$3095/2003983449.apply(Unknown Source)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.util.Optional.map(Optional.java:215)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.TileEntity.create(TileEntity.java:100)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR org.bukkit.craftbukkit.v1_14_R1.block.CraftBlockEntityState.createSnapshot(CraftBlockEntityState.java:52)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR org.bukkit.craftbukkit.v1_14_R1.block.CraftBlockEntityState.<init>(CraftBlockEntityState.java:31)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR org.bukkit.craftbukkit.v1_14_R1.block.CraftSkull.<init>(CraftSkull.java:25)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR org.bukkit.craftbukkit.v1_14_R1.block.CraftBlock.getState(CraftBlock.java:362)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR org.bukkit.craftbukkit.v1_14_R1.CraftChunk.getTileEntities(CraftChunk.java:132)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR com.sekwah.advancedportals.listeners.PortalPlacer.onChunkLoad(PortalPlacer.java:69)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR sun.reflect.GeneratedMethodAccessor38.invoke(Unknown Source)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.lang.reflect.Method.invoke(Method.java:498)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:316)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:520)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:505)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.Chunk.loadCallback(Chunk.java:508)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.PlayerChunk.lambda$1(PlayerChunk.java:221)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.PlayerChunk$$Lambda$2946/381666307.accept(Unknown Source)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.util.concurrent.CompletableFuture.uniAccept(CompletableFuture.java:656)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:632)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.util.concurrent.CompletableFuture.postFire(CompletableFuture.java:561)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:580)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.ChunkTaskQueueSorter.b(SourceFile:57)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.ChunkTaskQueueSorter$$Lambda$2972/1438884428.run(Unknown Source)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.ThreadedMailbox.e(SourceFile:83)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.ThreadedMailbox.a(SourceFile:123)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.ThreadedMailbox.run(SourceFile:91)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(SourceFile:135)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(SourceFile:114)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.ChunkProviderServer$a.executeNext(ChunkProviderServer.java:496)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.ChunkProviderServer.runTasks(ChunkProviderServer.java:192)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.MinecraftServer.aW(MinecraftServer.java:904)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:888)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeAll(SourceFile:99)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:871)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:805)
22.05 14:11:16 [Server] Spigot Watchdog Thread/ERROR java.lang.Thread.run(Thread.java:748)
Ahh i know what the problem is. Its the only piece of code that wasnt updated. I thought id removed that in 1.12
Actually could you check against the latest version of advanced portals? The offending line was removed 9 months ago in version 0.0.46
Hmm.. I think I see what you're saying. I don't see PortalPlacer.java in master or dev but's it definitely in the jar. I checked both the releases here in guthub and the bukkit download.
$ jar tf ~/Downloads/Advanced-Portals-0.0.49-snapshot.jar | grep Placer
com/sekwah/advancedportals/listeners/PortalPlacer.class
The current exports use the portals-old branch as there is a redesign i was part way through. I just decompiled the latest version and yea it seems to have the old code. I guess I forgot to upload a new one with that change then https://github.com/sekwah41/Advanced-Portals/blob/portals-old/src/main/java/com/sekwah/advancedportals/listeners/PortalPlacer.java
https://share.sekwah.com/Advanced-Portals-0.0.50-snapshot.jar I will be uploading a copy later but for now you can grab the file here