[BUG] AntiPopup breaks Log4JExploitFix
hasankayra04 opened this issue ยท 2 comments
Describe the bug
AntiPopup breaks Log4JExploitFix plugin.
To Reproduce
Steps to reproduce the behavior:
- Install AntiPopup & Log4JExploitFix.
- Send a chat message.
Expected behavior
Log4JExploitFix should have worked with the AntiPopup and shouldnt have spit out an error.
Screenshots
If applicable, add screenshots to help explain your problem.
Server information:
- Operating System (for example Rocky 9): Windows 10
- Server Software (for example Spigot): Petal(Purpur fork)
- Server Version (for example 1.19.2): 1.19.2
- Plugin list:
ActionHealth, AntiPopup, BungeeGuard, ClearLag, DisableCommands, DiscordSRV, Essentials, ExploitFixer, FastAsyncWorldEdit (WorldEdit), HamsterAPI, IllegalStack, Log4JExploitFix, LPC, LuckPerms, MOTD, MyCommand, Negativity, ore-control, Orebfuscator, PlaceholderAPI, PluginManager, ProtocolLib, Scoreboard-revision*, Skript, spark, SpigotPing, TitleManager, Vault, ViaBackwards, ViaVersion, WorldGuard
Logs
[02:49:09 ERROR]: [Log4JExploitFix] Unhandled exception occurred in onPacketSending(PacketEvent) for Log4JExploitFix
java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) ~[?:?]
at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) ~[?:?]
at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266) ~[?:?]
at java.util.Objects.checkIndex(Objects.java:359) ~[?:?]
at java.util.ArrayList.get(ArrayList.java:427) ~[?:?]
at dev.luzifer.log4jexploitfix.Log4JExploitFix$1.onPacketSending(Log4JExploitFix.java:52) ~[?:?]
at com.comphenix.protocol.injector.SortedPacketListenerList.invokeSendingListener(SortedPacketListenerList.java:195) ~[?:?]
at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketSending(SortedPacketListenerList.java:149) ~[?:?]
at com.comphenix.protocol.injector.PacketFilterManager.postPacketToListeners(PacketFilterManager.java:547) ~[?:?]
at com.comphenix.protocol.injector.PacketFilterManager.invokePacketSending(PacketFilterManager.java:521) ~[?:?]
at com.comphenix.protocol.injector.netty.manager.NetworkManagerInjector.onPacketSending(NetworkManagerInjector.java:99) ~[?:?]
at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector.processOutbound(NettyChannelInjector.java:571) ~[?:?]
at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector$2.doProxyRunnable(NettyChannelInjector.java:472) ~[?:?]
at com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.proxyRunnable(NettyEventLoopProxy.java:43) ~[?:?]
at com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.execute(NettyEventLoopProxy.java:252) ~[?:?]
at net.minecraft.network.Connection.sendPacket(Connection.java:433) ~[?:?]
at net.minecraft.network.Connection.send(Connection.java:380) ~[?:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.send(ServerGamePacketListenerImpl.java:2257) ~[?:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.send(ServerGamePacketListenerImpl.java:2243) ~[?:?]
at com.comphenix.protocol.reflect.accessors.DefaultMethodAccessor.invoke(DefaultMethodAccessor.java:23) ~[?:?]
at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector.sendServerPacket(NettyChannelInjector.java:292) ~[?:?]
at com.comphenix.protocol.injector.netty.channel.NettyChannelInjector.lambda$processOutbound$6(NettyChannelInjector.java:565) ~[?:?]
at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[petal-1.19.2.jar:git-petal-"cc69154"]
at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) ~[petal-1.19.2.jar:git-petal-"cc69154"]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1500) ~[petal-1.19.2.jar:git-petal-"cc69154"]
at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:486) ~[petal-1.19.2.jar:git-petal-"cc69154"]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1424) ~[petal-1.19.2.jar:git-petal-"cc69154"]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1194) ~[petal-1.19.2.jar:git-petal-"cc69154"]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:310) ~[petal-1.19.2.jar:git-petal-"cc69154"]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
[02:49:09 ERROR]: Parameters:
net.minecraft.network.protocol.game.ClientboundPlayerChatPacket@f61aaff[
a=PlayerChatMessage[signedHeader=SignedMessageHeader[previousSignature=null, sender=da675a0a-a2fd-31e0-ab27-a4b31d3e2475], headerSignature=empty, signedBody=SignedMessageBody[content=ChatMessageContent[plain=effef, decorated=literal{effef}, decorationResult=ModernResult[maybeAdventureComponent=io.papermc.paper.adventure.AdventureComponent@2d2f0939, hasNoFormatting=true, modernized=false]], timeStamp=2022-12-28T23:49:09.774Z, salt=0, lastSeen=LastSeenMessages[entries=[]]], unsignedContent=Optional[io.papermc.paper.adventure.AdventureComponent@fc1c063], filterMask=net.minecraft.network.chat.FilterMask@74a8f3b0]
b=b[chatType=7, name=io.papermc.paper.adventure.AdventureComponent@1e7cf9d7, targetName=null]
]
First of all, why do you have Log4JExploitFix at all? You seem to run a non vulnerable version of the server.
Second of all the plugin appear to support versions up to 1.18.2, maybe either your server needs a newer protocollib version?