AutoPickup

AutoPickup

88.9k Downloads

Mending and disable options

rigis1 opened this issue ยท 11 comments

commented
  • Everything I write about has been tested on the rights of the operator *
  1. Mending does not work, you have to manually turn off the collection of experience.
  2. Every time I leave the server my modification settings change (for example: I turned off automatic collection, after leaving the server and joining again the option turned itself on)
  3. No possibility to change basic parameters (currently everything is enabled but I would like to be able to set this)
commented

so config should be saving, and I have added some code to the Dev branch that should make mending work

commented

Can verify point number 2. Configuration resets on server restart. Additionally, commands (eg /ap reload) return (in plaintext) "/ap help", also valid for all submodules.

commented

how are you setting the config? ingame or via the UI/commands?

commented
commented

please provide your config file with all formatting intact

commented

Can confirm the same thing. (v 5.2.3)

Infinity Pick: false
Mob:
  AutoXP: false
  AutoPickup: true
AutoSmelt Compat Mode: true
Block AutoXP: false
Auto Chest: false
Full Inventory:
  Delete Item: false
  Warn: true
Gui:
  Contact Info: false
Allow BlockGui Permission: false
AutoBlock Quartz: true

When a player attempts to disable autopickup for themselves, it fails, too, and they still continue to auto pickup the items even when it says it has been disabled for them.

Running "/ap reload" does not cause AutoPickup to read the changed config, however, and AutoXP is thus not actually set to false.

commented
commented

I confirm that mending isn't working.

commented

I'm unable to do so until July 10th as I am out of office. My apologies. A note though: I didn't change much at all within the plugin. I noted that the lang.yml (if that's what it's called) also would reset. Maybe the plugin keeps replacing the config files without checking if they exist yet.

Just to check, did you mean July 10th or August 10th?

commented
commented
Infinity Pick: false
Mob:
  AutoXP: true
  AutoPickup: true
AutoSmelt Compat Mode: true
Block AutoXP: true
Auto Chest: true
Full Inventory:
  Delete Item: true
  Warn: true
Gui:
  Contact Info: true
Allow BlockGui Permission: false
AutoBlock Quartz: true

When I do this:
Infinity Pick: true

after stopping the server, then restarting it, all config files (even the messages one) are reset.

EDIT: Can't figure out how to retain formatting. I've attached a screenshot instead. - fixed, thank you x2!

image

EDIT 2: Looks like there's something wrong with the saveAll function on line 60 of Config.java.