Autorank

Autorank

380k Downloads

Keep getting Promoted

HighTide opened this issue · 23 comments

commented

Hi,

Everything works but for some reason all my players who passed the 1 hour mark keep getting the message that they are promoted every min or so.

this is my config:

ranks:
    Newbie:
        requirements:
            time:
                value: 1h
        results:
            rank change: Newbie;Irregular
            message: 'Congratulations, you are now a Irregular. After 7 Days you will be promoted to Regular.'
            command: 'broadcast &p played for 1 Hour and is now an Irregular!'
    Irregular:
        requirements:
            time:
                value: 7d
        results:
            rank change: Irregular;Regular
            message: 'Congratulations, you are now a Regular.'
            command: 'broadcast &p played for 1 Week and is now an Regular!'

I'm using Zpermissions as permissions manager.

Do you know how to fix it?

Regards Jurre

commented

^^^

commented

The same issue occurs with privileges due to the single group issue.

commented

By privileges you mean the Privileges permissions plugin?

commented

I thought we fixed this issue ages ago for Groupmanager..
Anyway, Vault always just passes on what the permissions API gives it without making too many changes. The GM api always returns all groups a member belongs to, including the inherited ones. And unlike zperms, there is no way to change this functionality.
As discussed here: MilkBowl/Vault#201

What I did in previous versions of Autorank (and I thought the current version also did) is just disable ranking for secondary groups, do getPrimaryGroup() instead of getPlayerGroups(). This does limit the Autorank functionality a bit for GM but at least it makes it usable.

commented

Doesn't even have to be an option, Autorank should just know for which permissions plugins it has to turn off secondary groups. I know it used to do this for GM back in version 1.7.

commented

Would it be possible to add a configuration option for the times when that happens? A option for a singular mode to allow the plugins that support singular groups while not limiting the multiple group plugins?

commented

There is a GroupManager permisssions handler. That one is a special one built for GM because it uses secondary groups. I'll try to change the Vault handler to use getPrimaryGroup(). Watch for a dev build that has a commit changing that. Then just download it and let us know whether it worked.

commented

I used build 145 and 146 that use the commit 81a935d and neither are ranking me up properly when using privileges.

commented

Hmm, I think Vault is messing with Zpermissions. I'll take a look and try to fix it but I'm not sure if I can.

commented

This has been happening to me as well. Please fix!

I am using the latest version, and use GroupManager for my permissions.

commented

This seems to happen when the Vault connector is not working properly.

commented

What can we do to remedy the situation? I have updated Vault to the 1.7.2 version to no avail. All other plugins that I have installed that utilise Vault work perfectly.

commented

I'll tell you how I fixed it. The problem is not in vault and partially in this plugin. It can be easily fixed by going to the zperm config. Somewhere at the bottom there is a potion to only return 1 group. Instead of all the groups, you inherit. You need to turn that off. (can't remember the name)

What happens is the following: you have the ranks guest, player, long-player.
Long player inherits from player, player from guest. With that option on if you are in old player zperm will say: player xxx is in group guest, player and old player.

This plugin keeps thinking it needs to promote you cause it still checks if you're in the group guest.

Sorry, I posted from my phone.

commented

Hi - what about GroupManager? I use GroupManager for my permissions and still encounter the same issue.

commented

Maybe there is a option to only return 1 group? I really dont know, never used groupmanager

Verstuurd vanaf mijn iPhone

Op 15 jan. 2014 om 01:27 heeft henryaustin404 [email protected] het volgende geschreven:

Hi - what about GroupManager? I use GroupManager for my permissions and still encounter the same issue.


Reply to this email directly or view it on GitHub.

commented

Hmm, very odd. What version of GroupManager are you running?

commented

I am using GroupManager version 2.0 (2.12.1) Phoenix.

(the latest one)

commented

Hmm, very strange. I'll see what I can do to remedy this problem.

commented

Hi Staartvin - have you made any progress on this yet?

Thanks! :)

commented

I'm very confused. You should try 2.8 when it is approved. I'm not sure what can solve this.

commented

Alright - I have updated to 2.8, and still encounter the same result.

commented

AutoRank is seemingly giving away a rank every time the plugin checks for time played (I have it set to 5 minutes).

commented

Same problem with PEX.