Double snow layer generated / terrain populated twice
Squawkers13 opened this issue · 22 comments
I'm getting a stacktrace on server startup (after the "Done!" message):
[13:34:57 WARN]: org.apache.commons.lang.UnhandledException: Plugin 173generator v2.3-12-gb246b7e generated an exception while executing task 10 at org.bukkit.craftbukkit.v1_9_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.NoSuchMethodError: org.bukkit.Server.getOnlinePlayers()[Lorg/bukkit/entity/Player; at com.github.barteks2x.b173gen.org.mcstats.Metrics.postPlugin(Metrics.java:335) at com.github.barteks2x.b173gen.org.mcstats.Metrics.access$400(Metrics.java:57) at com.github.barteks2x.b173gen.org.mcstats.Metrics$1.run(Metrics.java:223) at org.bukkit.craftbukkit.v1_9_R1.scheduler.CraftTask.run(CraftTask.java:71) at org.bukkit.craftbukkit.v1_9_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53) ... 3 more
I'm also finding snow is generating abnormally.
They're not client side though. Physics behaves normally with multiple players until a block update triggers.
The error has absolutely nothing to do with what the plugin does, I'm not sure how it affects it.
MCStats is broken on 1.9.
As for another layer of snow - the only explanation I can find now is that it's done twice... somehow.
When I right clicked the snow, whole sheets of it would disappear, so maybe the chunks need to refresh or something.
It took me a long time to get it started, but I finally got it back into usable state.
After doing some unrelated changes in the code, I can't find the bug myself. Is it still an issue on 1.10?
Do you have a binary I could download and test?
The build server on the plugin page doesn't seem to work.
https://dl.dropboxusercontent.com/u/54602353/b173gen-2.3-13-ge4741c1.jar?dl=1
I didn't change anything in snow generation code, but I don't see this issue on craftbukkit 1.10.2.
Vanilla 1.10.2 client with spigot 1.10.2 server
World generated with multiverse
The snow behaves exactly as before.
On Craftbukkit, with only Multiverse and this plugin installed the glitch is still present in a newly generated world.
I've actually also noticed another possible bug with sand as well...
What plugins do you have? When I generate new world without multiverse and without any other plugins it works fine. I think some plugin exposes this bug, but I don't know which plugin. Try removing plugins until it starts working again. And try it on craftbukkit instead of spigot if removing plugins doesn't change anything.
As for sand, compare it against actual beta 1.7.3 world with the same seed. It should at least be similar in the same place. There are a few differences (for example caves are offset by one block, and all consequences that follow), but these are minor things.
If it doesn't happen in beta 1.7.3, I must have swapped x and z axes in some noise generator. But as far as I know, there is a "glitch" in Minecraft noise generator that happens along Y axis that makes the noise non-continuous (this glitch exists since the first infdev version and still exists in 1.10.2), and the noise used to choose sand/dirt/gravel is used with Y axis.
Did you try without multiverse?
Without Multiverse the problem disappears! 😃
I haven't looked at beta 1.7.3 but are you sure the sand is supposed to generate in square patterns?
This is craftbukkit/spigot bug Reported it here: https://hub.spigotmc.org/jira/browse/SPIGOT-2575
I will check that again, but last time I did it, I got exactly the same thing on beta 1.7.3.
Now I need to figure out what multiverse does differently that causes double-layer of snow.
Forked, merged, built, and tested, and I can confirm that @coolsa's change fixes the bug when using Spigot and Multiverse.
It hides the issue, but doesn't really fix it. 'proper' fix is to not populate the same chunk again.
Just created a pull request that should fix it. Changed the 'if' statement that generates the snow.
For some strange reason the issue decided to disappear just before my attempt to fix it...
Probably the Spigot update
On Sat, Aug 6, 2016, 3:33 PM Bartosz Skrzypczak [email protected]
wrote:
For some strange reason the issue decided to disappear just before my
attempt to fix it...—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGtP6X4SdM-SesdSXUNJhnry1g8dU06uks5qdQvOgaJpZM4ID8Cv
.Sent from Inbox
I accidentally fixed it by changing !isLiqiod to isSolid check. But I will provide proper workaround anyway,