Better Beds

Better Beds

7k Downloads

Plugin depending player ignoring support

Phoenix616 opened this issue ยท 5 comments

commented

Don't count AFK players. For example by hooking into Essentials or maybe even running our own AFK checks (although I don't really want to get into this, might be only something for future updates if it really is needed)

commented

FYI I'm working on a simple plugin that sets the betterbeds.ignore permission to true while WhosAFK set's a player afk

commented

You could also just fork and implement it directly into the plugin ;)

commented

You could also just fork and implement it directly into the plugin ;)

Yes, however if you look at my approach you'll see it makes more sense as a seperate plugin for a few reasons; most importantly, the code is specific to two plugins, you may decide there are better alternatives to WhosAFK, or someone using WhosAFK may wish to use an alternative bed plugin.

Also this is the first time I've used Java or the Bukkit API, so it made more sense for me to work on something small and independant.

EDIT: Thought about the WhosAFK from a different approach, and I have come up with a simpler method than my integration plugin in PR #6

commented

Some more thoughts about this issue:

It should generally support ignoring people due to multiple different parameters, the most obvious ones being the player being afk or the player being vanished. For that each supported plugin should use a different maven module and the different ignore types be configurable in the config.

AFK status as well as vanishing would ideally be handled by a ServiceProvider similarly to how Vault provides a unified interface, maybe something to integrate into Tresor?

commented

has it been implemented since 2016 in the meantime (for example essentialsx)?