Cannons

Cannons

117k Downloads

Gunpowder loading/block spawn duration addition.

jamesol1 opened this issue · 8 comments

commented

First of all thanks for updating the images on the wiki! Not sure if you are still up for making some additions but here's is some i'd really like if you are.

Right so i know theres a way of autoloading your cannon with redstone and a chest. I was wondering if you could make an option which basically automatically loads gunpowder into the cannon when you put a projectile in. It removes the need to use a lever and setup redstone etc and you still get the novelty of adding the projectile in.

I was also wondering if you could add a option which gives the blocks that can be spawned via 'spawnOnExplosion' a duration.

Many thanks!

commented

If you want to use a projectile which contains gunpowder and a shell I recommend to use "needsGunpowder: false".
This way you can directly load the projectile, without loading the gunpowder.
Or do you want to detect the projectile when you put it in the chest and automatically notify the cannon next to it to load?

Do you mean the blocks for 'spawnOnExplosion' should vanish after a certain time?

commented

I saw this setting "needsGunpowder: false" but was hoping to still include the novelty of adding gunpowder, just without the pain of manually putting it in. But without needing the redstone contraption to trigger twice to load both gunpowder and the projectile (aka the auto-loading system). Also considering i'd be putting cannons on small ships, having the redstone setup/chest takes up quite a lot of space.
My thinking was upon loading in a projectile it would automatically take gunpowder out of your inventory and load it into the cannon. If you didn't i guess have any.. you'd then have to go grab some and manually add it into the cannon like normal.

EDIT: If you do have the time to add stuff, this one would be the one i'd say to prioritise:
"Do you mean the blocks for 'spawnOnExplosion' should vanish after a certain time?"
Exactly. I was hoping there could be a duration option (similar to how there is with the aiming cobweb trail).

commented

All of the points are possible to implement, I will have a look.

commented

I added a option to autoload the gunpowder when you load the projectile, it is a little bit strange because you don't get a message that the gunpowder was loaded.

commented

Ah thanks a lot!
I was wondering if the duration time for spawning block explosion is doable, that would be quite a neat addition, the server im helping out would greatly benefit from a specific use of this.

commented

It can definitely bet done. There is already a code in the program which removes the smoke, but these are only virtual.
However, I try to limit myself to bug fixes at the moment.

commented

No worries, we have found a work around, its not a huge priority, something i might use for a project down the line.

commented

I added a option to autoload the gunpowder when you load the projectile, it is a little bit strange because you don't get a message that the gunpowder was loaded.

Thanks for adding this. One bug i noticed though is that if people put gunpowder into their cannon, and THEN try to add the projectile (with the autoload gunpowder on placing projectile config option)... it doesnt let them add it. and people need to dismantle their cannon and rebuild it, as it does not fire and cannot load the projectile.
If theres no easy fix without removing the features then dont worry.

https://www.youtube.com/watch?v=MDnsQKfi_QA&ab_channel=JohnF1
Video of it for reference.