ChatFeelings

ChatFeelings

331k Downloads

Feelings permissions do not appear to be available or enforced

EgamhCR opened this issue · 2 comments

commented

Bug Description (Required)
Trying to prevent a few of the feelings from being available.
For example stab and murder
Added permissions
chatfeelings.murder false
chatfeeligns.stab false
Appears unaffected by permissions.

The spoiler for commands and permissions implies there are permissions for each of the feelings.
/bite⠀⠀⠀⠀⠀⠀⠀chatfeelings.bite
/stab⠀⠀⠀⠀⠀⠀⠀chatfeelings.stab
/punch⠀⠀⠀⠀⠀⠀⠀chatfeelings.punch
/murder⠀⠀⠀⠀⠀⠀⠀chatfeelings.murder

LP verbose command results implies the code is not checking. I did not debug the code yet.
[LP] Forcing Prentis to execute command stab Egamh and reporting all checks made....
[LP] The command execution completed, but no permission checks were made.
[LP] This might be because the plugin runs commands in the background (async). You can still use verbose manually to detect checks made like this.

Perhaps I have this configured incorrectly...

Perhaps this is a feature request instead.
If it is a feature, the /feelings command should display only feelings that the player has perms to match.

How to Reproduce: (If unsure, you may leave this out)
How can we recreate this bug?

  1. Add false permissions to your permissions handler for the user or group / feeling you are trying to prevent using.
  2. Run the command
  3. Evaluate if it worked..

Environment Info (Required)
Please replace the placeholders below with the corresponding information:

  • Minecraft Server Version: [e.x. 1.18.2]
  • Server Type: [e.x. Paper] git-Paper-228
  • ChatFeelings Version: (Do /cf version to check) [e.x v4.8]
commented

Hi there! Can you confirm that "Use-Feeling-Permissions" is set to true in your conifg.yml?

commented