ChestShop (iConomyChestShop)

ChestShop (iConomyChestShop)

6M Downloads

Worldguard Flag not working

DrPanic opened this issue · 4 comments

commented

Plugin Version

ChestShop's version is: 3.10-SNAPSHOT (build 131)

Plugin Config

PREFERRED_ECONOMY_PLUGIN: ""
#(When not using Vault) Preferred economy plugin to use (iConomy/BOSEconomy/Essentials).

SHOP_INTERACTION_INTERVAL: 1000
#(In 1/1000th of a second) How often can a player use the shop sign?
IGNORE_CREATIVE_MODE: false
#Do you want to allow using shops to people in creative mode?
REVERSE_BUTTONS: false
#If true, people will buy with left-click and sell with right-click.
SHIFT_SELLS_IN_STACKS: true
#If true, people will be able to buy/sell in 64 stacks while holding the crouch button.
SHIFT_ALLOWS: "ALL"
#What can you do by clicking shift with SHIFT_SELLS_IN_STACKS turned on? (ALL/BUY/SELL)
ALLOW_SIGN_CHEST_OPEN: true
#Can shop's chest be opened by owner with right-clicking a shop's sign?
ALLOW_LEFT_CLICK_DESTROYING: true
#If true, when you left-click your own shop sign you won't open chest's inventory, but instead you will start destroying the sign.

REMOVE_EMPTY_SHOPS: false
#If true, if the shop is empty, the sign is destroyed and put into the chest, so the shop isn't usable anymore.
REMOVE_EMPTY_CHESTS: false
#If true, if the REMOVE_EMPTY_SHOPS option is turned on, the chest is also destroyed.

ADMIN_SHOP_NAME: "TerraShop"
#First line of your Admin Shop's sign should look like this:
SERVER_ECONOMY_ACCOUNT: "TerraShop"
#The economy account which Admin Shops should use and to which all taxes will go
BANK_MEMBERS_ALLOWED: true
#Whether bank account members (if available) can create shops on its behalf
TAX_AMOUNT: 0
#Percent of the price that should go to the server's account. (100 = 100 percent)
BANK_TAX_AMOUNT: 0
#Percent of the price that should go to the server's account when buying from a bank.
SERVER_TAX_AMOUNT: 0
#Percent of the price that should go to the server's account when buying from an Admin Shop.
SHOP_CREATION_PRICE: 0.0
#Amount of money player must pay to create a shop
SHOP_REFUND_PRICE: 0.0
#How much money do you get back when destroying a sign?

BLOCK_SHOPS_WITH_SELL_PRICE_HIGHER_THAN_BUY_PRICE: true
#Should we block shops that sell things for more than they buy? (This prevents newbies from creating shops that would be exploited)

ALLOW_MULTIPLE_SHOPS_AT_ONE_BLOCK: false
#Do you want to allow other players to build a shop on a block where there's one already?
ALLOW_PARTIAL_TRANSACTIONS: true
#Can shops be used even when the seller doesn't have enough items? (The price will be scaled adequatly to the item amount)

SHOW_MESSAGE_OUT_OF_STOCK: true
#Do you want to show "Out of stock" messages?
SHOW_TRANSACTION_INFORMATION_CLIENT: true
#Do you want to show "You bought/sold... " messages?
SHOW_TRANSACTION_INFORMATION_OWNER: true
#Do you want to show "Somebody bought/sold... " messages?

LOG_TO_FILE: true
#If true, plugin will log transactions in its own file
LOG_TO_CONSOLE: true
#Do you want ChestShop's messages to show up in console?
LOG_TO_DATABASE: false
#If true, plugin will log transactions in EBean database
RECORD_TIME_TO_LIVE: -1
#How long should transaction information be stored in the database (in seconds, -1 means forever)?

STACK_TO_64: false
#Do you want to stack all items up to 64 item stacks?
USE_BUILT_IN_PROTECTION: false
#Do you want to use built-in protection against chest destruction?
STICK_SIGNS_TO_CHESTS: false
#Do you want to have shop signs "stick" to chests?
TURN_OFF_DEFAULT_PROTECTION_WHEN_PROTECTED_EXTERNALLY: false
#EXPERIMENTAL: Do you want to turn off the default protection when another plugin is protecting the block? (Will leave the chest visually open - CraftBukkit bug!)
TURN_OFF_SIGN_PROTECTION: true
#Do you want to turn off the default sign protection? Warning! Other players will be able to destroy other people's shops!
TURN_OFF_HOPPER_PROTECTION: true
#Do you want to disable the hopper protection, which prevents the hoppers from taking items out of chests?
PROTECT_CHEST_WITH_LWC: true
#Do you want to protect shop chests with LWC?
PROTECT_SIGN_WITH_LWC: true
#Do you want to protect shop signs with LWC?

GENERATE_STATISTICS_PAGE: false
#If true, plugin will generate shop statistics webpage.
STATISTICS_PAGE_PATH: "webpath: /var/www/survival/ChestShop/website.html"
#Where should your generated website be saved?
STATISTICS_PAGE_GENERATION_INTERVAL: 120
#How often should the website be generated?

WORLDGUARD_INTEGRATION: true
#Do you want to only let people build inside regions?
WORLDGUARD_USE_FLAG: true
#Do you want to only let poeple build inside region flagged by doing /region regionName flag chestshop allow?
WORLDGUARD_USE_PROTECTION: true
#Do you want ChestShop to respect WorldGuard's chest protection?

HEROES_EXP: 0.0
#How much Heroes exp should people get for creating a ChestShop?

TURN_OFF_UPDATES: false
#Do you want to turn off the automatic updates of ChestShop?
ALLOW_AUTO_ITEM_FILL: true
#Can '?' be put in place of item name in order for the sign to be auto-filled?

REMOVE_LWC_PROTECTION_AUTOMATICALLY: true
#Should the chest's LWC protection be removed once the shop sign is destroyed? 


AUTHME_HOOK: true
#Do you want to deny shop access to unlogged users?
AUTHME_ALLOW_UNREGISTERED: false
#Do you want to allow shop access to unregistered users? (Example: registration is optional)


CACHE_SIZE: 1000
#How large should the internal uuid and name caches be?
SHOW_MESSAGE_FULL_SHOP: true
#Do you want to show "Full shop" messages?

CSTOGGLE_TOGGLES_OUT_OF_STOCK: false
#Can players hide the "Out of stock" messages with /cstoggle?
CSTOGGLE_TOGGLES_FULL_SHOP: false
#Can players hide the "Full shop" messages with /cstoggle?

SHOWITEM_MESSAGE: true
#Add icons and make item names hoverable in transaction messages when ShowItem is installed?


#What containers are allowed to hold a shop? (Only blocks with inventories work!)
SHOP_CONTAINERS: 
- "CHEST"
- "TRAPPED_CHEST"
#Do you want to allow using shops to people who have access to it due to their permissions? (owners are always ignored)
IGNORE_ACCESS_PERMS: true
#A list of worlds in which to remove empty shops with the previous config. Case sensitive. An empty list means all worlds.
REMOVE_EMPTY_WORLDS: 
- "world1"
- "world2"
#How many decimal places are allowed at a maximum for prices?
PRICE_PRECISION: 2

#Should all shop removals be logged to the console?
LOG_ALL_SHOP_REMOVALS: true

Server Version

This server is running Paper version git-Paper-621 (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT)

Server Log

What other plugins are you running?

WorldGuard 7.0.0-beta-03;e51a220

What is happening?

Although no allow-shop flag exists, shops can be created. There is no error in the log.

What did you expect to happen?

The shop creation should be aborted without corresponding flags.

Additional context

Bug exist in Build 146 too.

commented
commented

Same with latest build of WorldGuard and ChestShop.

Edit: Just tested a little bit with a clean, new Server. The Flag is not registered from ChestShop. Maybe WorldGuard is in the initializePlugin Methode not completly loaded and can not register/load the Flag?

commented

Argh. I think i found the Problem: The Flag is registered when the option WORLDGUARD_USE_FLAG is activated in the config file. But the config is loaded when ChestShop is enabling and not before. So its always false.

commented

Good catch, should probably still work fine if flags are register in the onEnable.

EDIT: Hm, seems like you can only register them before WorldGuard is enabled... :S