ChestShop (iConomyChestShop)

ChestShop (iConomyChestShop)

6M Downloads

Plugin uses wrong notification

Vimppura opened this issue ยท 5 comments

commented

Plugin Version

3.10-SNAPSHOT (build 148)

Server Version

git-Paper-70 (MC: 1.14.2)

What is happening?

  1. Player tries to create shop with invalid item id
  2. Plugin tells player "You don't have permission to do that!" instead of "You have specified an invalid item id!"

What did you expect to happen?

Plugin should use node INCORRECT_ITEM_ID from local.yml. Instead it uses NO_PERMISSION. I could change NO_PERMISSION to give another message to players but it also affects the message in other purposes.

commented

Can you please provide the item/sign that causes this?

commented

It is caused with every sign that there is and with every wrong item id you write. Tho it doesnt matter if you right the correct id with big or small letters, both works.

commented

Which permissions do you have assigned? Also can you make sure that the player you are testing that has the ChestShop.shop.create permission? (Via your permission plugin's resolving/check command, not just manually in the list)

commented

Players have permission ChestShop.shop.* and I have Vanilla Op. Same issue with both WHEN you write the item id wrong. We have no problem creating a shop when id is written correctly. So the only problem here is that the plugin uses wrong local error message when item id is written incorrectly and it's confusing alot of people.

Plugin uses NO_PERMISSION when it should be using INCORRECT_ITEM_ID

commented

Well it shows the correct message for me and the only way I can see that that error could happen is by players not having the ChestShop.shop.create permission, please make sure that that permission (or the lowercase version) is actually resolving to true.