ChestShop (iConomyChestShop)

ChestShop (iConomyChestShop)

Bukkit Plugins
6M Downloads

Command to allow admins/mods to buy/sell from shop signs

JRoy opened this issue ยท 9 comments

commented

Describe the solution you'd like

A command to toggle the OTHER_NAME_ACCESS permission to allow admins/mods to buy from chestshops without them just opening the chests

Describe alternatives you've considered

If I'm not mistaking you could make a change here

ChestShop-3/src/main/java/com/Acrobot/ChestShop/Listeners/Player/PlayerInteract.java

Lines 118 to 132 in a95f731

if (ChestShopSign.hasPermission(player, OTHER_NAME_ACCESS, sign) && !ChestShopSign.isAdminShop(sign)) {
if (Properties.IGNORE_ACCESS_PERMS || ChestShopSign.isOwner(player, sign)) {
if (Properties.ALLOW_SIGN_CHEST_OPEN && !(Properties.IGNORE_CREATIVE_MODE && player.getGameMode() == GameMode.CREATIVE)) {
if (player.isSneaking() || player.isInsideVehicle()
|| (Properties.ALLOW_LEFT_CLICK_DESTROYING && action == LEFT_CLICK_BLOCK && ChestShopSign.hasPermission(player, OTHER_NAME_DESTROY, sign))) {
return;
}
event.setCancelled(true);
showChestGUI(player, block, sign);
return;
}
// don't allow owners or people with access to buy/sell at this shop
return;
}
}

commented

Can you please re-explain what the command should do?
Do you mean that shop owners can buy from themselves? Or do you mean Op users?
Also should the command have any parameters?

commented

@g--o I'd like users with the ChestShop.othername.access permission to do a command that toggles that permission so that users with that permission can purchase/sell to shops. The owner of a shop would still not be able to purchase from/sell to their own shop.

commented

@Phoenix616 please close this

commented

Implemented in 88a23a3.

commented

@g--o please don't forget to claim your bounty on bountysource, seeing as they are going to keep any bounty that is older than two years after June 1st I would highly advice to at least claim it even though their ETH account linking is still not working properly :S

commented

@Phoenix616 thanks a lot, i sorted a paypal transaction instead of the eth and opened an issue on bountysource's repo; that platform should really get itself together..

anyway you should probably email them to make sure everything's in order on your end as well; thanks again :)

commented

Well I don't really have any control of the bounties there, it's all in the hands of bountysource unfortunately :S And seeing as you resolved it I think that you should just get that if in any way possible.

commented

@Phoenix616 oh I see, i'll try. thanks again for the concern :)