Slimefun player_head items no longer working in ChestShop
mrcoffee1026 opened this issue ยท 1 comments
Plugin Version
[14:21:26 INFO]: ChestShop's version is: 3.10-SNAPSHOT (build 152)
Plugin Config
TURN_OFF_UPDATES: false
#Do you want to turn off the automatic updates of ChestShop?
CACHE_SIZE: 1000
#How large should the internal uuid and name caches be?
SHOP_INTERACTION_INTERVAL: 750
#(In 1/1000th of a second) How often can a player use the shop sign?
IGNORE_CREATIVE_MODE: true
#Do you want to allow using shops to people in creative mode?
REVERSE_BUTTONS: false
#If true, people will buy with left-click and sell with right-click.
SHIFT_SELLS_IN_STACKS: true
#If true, people will be able to buy/sell in 64 stacks while holding the crouch button.
SHIFT_ALLOWS: "SELL"
#What can you do by clicking shift with SHIFT_SELLS_IN_STACKS turned on? (ALL/BUY/SELL)
ALLOW_SIGN_CHEST_OPEN: true
#Can shop's chest be opened by owner with right-clicking a shop's sign?
ALLOW_LEFT_CLICK_DESTROYING: true
#If true, when you left-click your own shop sign you won't open chest's inventory, but instead you will start destroying the sign.
REMOVE_EMPTY_SHOPS: false
#If true, if the shop is empty, the sign is destroyed and put into the chest, so the shop isn't usable anymore.
REMOVE_EMPTY_CHESTS: false
#If true, if the REMOVE_EMPTY_SHOPS option is turned on, the chest is also destroyed.
ADMIN_SHOP_NAME: "Admin Shop"
#First line of your Admin Shop's sign should look like this:
SERVER_ECONOMY_ACCOUNT: ""
#The economy account which Admin Shops should use and to which all taxes will go
TAX_AMOUNT: 0
#Percent of the price that should go to the server's account. (100 = 100 percent)
SERVER_TAX_AMOUNT: 0
#Percent of the price that should go to the server's account when buying from an Admin Shop.
SHOP_CREATION_PRICE: 0.0
#Amount of money player must pay to create a shop
SHOP_REFUND_PRICE: 0.0
#How much money do you get back when destroying a sign?
BLOCK_SHOPS_WITH_SELL_PRICE_HIGHER_THAN_BUY_PRICE: true
#Should we block shops that sell things for more than they buy? (This prevents newbies from creating shops that would be exploited)
ALLOW_MULTIPLE_SHOPS_AT_ONE_BLOCK: false
#Do you want to allow other players to build a shop on a block where there's one already?
ALLOW_PARTIAL_TRANSACTIONS: true
#Can shops be used even when the seller doesn't have enough items? (The price will be scaled adequately to the item amount)
ALLOW_AUTO_ITEM_FILL: true
#Can '?' be put in place of item name in order for the sign to be auto-filled?
SHOW_MESSAGE_OUT_OF_STOCK: true
#Do you want to show "Out of stock" messages?
SHOW_MESSAGE_FULL_SHOP: true
#Do you want to show "Full shop" messages?
CSTOGGLE_TOGGLES_OUT_OF_STOCK: false
#Can players hide the "Out of stock" messages with /cstoggle?
CSTOGGLE_TOGGLES_FULL_SHOP: false
#Can players hide the "Full shop" messages with /cstoggle?
SHOW_TRANSACTION_INFORMATION_CLIENT: true
#Do you want to show "You bought/sold... " messages?
SHOW_TRANSACTION_INFORMATION_OWNER: true
#Do you want to show "Somebody bought/sold... " messages?
LOG_TO_FILE: true
#If true, plugin will log transactions in its own file
LOG_TO_CONSOLE: false
#Do you want ChestShop's messages to show up in console?
STACK_TO_64: false
#Do you want to stack all items up to 64 item stacks?
USE_BUILT_IN_PROTECTION: true
#Do you want to use built-in protection against chest destruction?
STICK_SIGNS_TO_CHESTS: true
#Do you want to have shop signs "stick" to chests?
TURN_OFF_DEFAULT_PROTECTION_WHEN_PROTECTED_EXTERNALLY: false
#EXPERIMENTAL: Do you want to turn off the default protection when another plugin is protecting the block? (Will leave the chest visually open - CraftBukkit bug!)
TURN_OFF_SIGN_PROTECTION: false
#Do you want to turn off the default sign protection? Warning! Other players will be able to destroy other people's shops!
TURN_OFF_HOPPER_PROTECTION: true
#Do you want to disable the hopper protection, which prevents the hoppers from taking items out of chests?
PROTECT_CHEST_WITH_LWC: true
#Do you want to protect shop chests with LWC?
PROTECT_SIGN_WITH_LWC: true
#Do you want to protect shop signs with LWC?
REMOVE_LWC_PROTECTION_AUTOMATICALLY: true
#Should the chest's LWC protection be removed once the shop sign is destroyed?
WORLDGUARD_INTEGRATION: false
#Do you want to only let people build inside regions?
WORLDGUARD_USE_FLAG: true
#Do you want to only let poeple build inside region flagged by doing /region regionName flag chestshop allow?
WORLDGUARD_USE_PROTECTION: false
#Do you want ChestShop to respect WorldGuard's chest protection?
AUTHME_HOOK: false
#Do you want to deny shop access to unlogged users?
AUTHME_ALLOW_UNREGISTERED: false
#Do you want to allow shop access to unregistered users? (Example: registration is optional)
HEROES_EXP: 0.0
#How much Heroes exp should people get for creating a ChestShop?
#A list of worlds in which to remove empty shops with the previous config. Case sensitive. An empty list means all worlds.
REMOVE_EMPTY_WORLDS:
- "world1"
- "world2"
#Add icons and make item names hoverable in transaction messages when ShowItem is installed?
SHOWITEM_MESSAGE: true
#What containers are allowed to hold a shop? (Only blocks with inventories work!)
SHOP_CONTAINERS:
- "CHEST"
- "TRAPPED_CHEST"
#Do you want to allow using shops to people who have access to it due to their permissions? (owners are always ignored)
IGNORE_ACCESS_PERMS: true
#How many decimal places are allowed at a maximum for prices?
PRICE_PRECISION: 2
#Should all shop removals be logged to the console?
LOG_ALL_SHOP_REMOVALS: true
#How many seconds do you want to wait before showing notifications for the same shop to the owner again?
NOTIFICATION_MESSAGE_COOLDOWN: 10
Server Version
This server is running Paper version git-Paper-234 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)
Server Log
What other plugins are you running?
The relevant one you need to be aware of:
[14:27:23 INFO]: Paper v1_14_R1
[14:27:23 INFO]:
[14:27:23 INFO]: CS-CoreLib vDEV - 78 (git 199e1b1e)
[14:27:23 INFO]: Slimefun vDEV - 357 (git bcbe1625)
[14:27:23 INFO]:
[14:27:23 INFO]: Installed Addons (11)
[14:27:23 INFO]: Barrels vDEV - 7 (git 0d14dd9f)
[14:27:23 INFO]: SlimeXpansion vDEV - 4 (git 5bf10c29)
[14:27:23 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[14:27:23 INFO]: ChestTerminal vDEV - 17 (git 933a7d36)
[14:27:23 INFO]: HotbarPets vDEV - 20 (git cd87bc60)
[14:27:23 INFO]: ExoticGarden vDEV - 22 (git a855f5b7)
[14:27:23 INFO]: SoulJars vDEV - 4 (git 4a600aa2)
[14:27:23 INFO]: SlimefunOreChunks vDEV - 2 (git 24d90a3e)
[14:27:23 INFO]: ElectricSpawners vDEV - 5 (git c3f8cc9d)
[14:27:23 INFO]: PrivateStorage vDEV - 6 (git b012877e)
[14:27:23 INFO]: DyedBackpacks vDEV - 1 (git 4b4d1f0f)
What is happening?
Up until recently players have been happily creating chest shops with player_head items from slimefun in them. As of a recent build of slimefun, these signs now have ceased to function and new signs cannot be made... errors in the console as included above. Errors in the ChestShop.log whenever attempting to create a new sign or use the /iinfo command on those items:
2019/12/06 09:37:05 Error while generating shop sign item name
2019/12/06 09:38:39 Error while generating full item name
What did you expect to happen?
Shops should still be operating fine, these sign shops have been working with these items for ages. The slimefun devs are telling me recent builds should have not have had an effect and that your plugin should be able to appropriately parse materials data by now within 1.14.
Additional context
https://github.com/ChestShop-authors/ChestShop-3/blob/master/src/main/java/com/Acrobot/Breeze/Utils/MaterialUtil.java#L237
Yeah, just report that. It's on them or something hooking into it
I'll update to a later build if it resolves the problem but I don't believe any of the more recent builds had anything dealing with any material changes, let me know if I missed something.