ChestShop (iConomyChestShop)

ChestShop (iConomyChestShop)

6M Downloads

ChestShop does not respect LWC limits.

andrewkm opened this issue · 8 comments

commented

Setup:
PaperSpigot Build 105
Chestshop Build 171
LWCX: https://github.com/pop4959/LWCX (Latest as of this report)

TL;DR if user is at maximum limit for lwc (check via /climits) they can still create chestshops.
Config: https://pastebin.com/p7nLyx2X

commented

That's rather strange, ChestShop is firing the correct event which the LimitsModule is listening on and would cancel if the limit is reached. Is the message of the reached limit send or not? Because if not then it might be an issue with LWCX' limits module rather than ChestShop itself.

commented

No, the max limits message doesn’t send when limit is full and you’re making a chestshop, it simply lets it go through.

commented

@Phoenix616 with your latest changes, it allows the shop to be created, but the shop is NOT protected as the climits are reached.

As such, the bug is half fixed, (it doesn't protect the shop), however the shop should not be created in the first place if the limits are full :)

commented

Hm, this might require an extra config option seeing as some might want the shop to still get created but just not protected.

commented

Any updates on this?
Not sure if it's been addressed or not yet.

commented

@Phoenix616 please re-open, this is still broken.
Using latest chestshops and LWCX as of this post.

Config has:

# Should LWC limits block shop creations?
LWC_LIMITS_BLOCK_CREATION: true

Limits are as such:
https://i.imgur.com/g09BaUy.png

On shop creation:
https://i.imgur.com/v9FPOXP.png

commented

Ah yes, limitsv2 was released a long time ago, but indeed is the new one. :)
Thanks! Confirmed fixed :)

commented

Should be fixed now. Apparently LWC has two different limit modules? :S