ChestShop (iConomyChestShop)

ChestShop (iConomyChestShop)

6M Downloads

Please add support for Slimefun plugin

andris155 opened this issue ยท 6 comments

commented

Is your feature request related to a problem? Please describe.

Currently the Slimefun machines breaks the protected shop chests.

Describe the solution you'd like

Chestshop support the Slimefun plugin, and Slimefun machines no break the protected shop chests.

Additional context

https://github.com/Slimefun/Slimefun4/wiki/Protection-plugins
Slimefun/Slimefun4#2453

commented

This is something which Slimefun would need to properly support. ChestShop already stops block breaks of protected shops, Slimefun needs to call and check the cancel state of the BlockBreakEvent. Alternatively you can simply use LWC and auto-protect shops I guess.

commented

This is something which Slimefun would need to properly support. ChestShop already stops block breaks of protected shops, Slimefun needs to call and check the cancel state of the BlockBreakEvent. Alternatively you can simply use LWC and auto-protect shops I guess.

The thing here is: Slimefun has various machines which break blocks without a Player being present.
That's why there is no Event to call or listen to.
Instead we use an API to interact with most protection plugins which we outlined here:
https://github.com/Slimefun/Slimefun4/wiki/Protection-plugins

Many plugins already added integration for their plugin this way and I would believe that you may do a better job in adding ChestShop to this than we would, since we aren't familiar with the ChestShop API in any way.
The wiki article that @andris155 has linked should cover how to add compatibility.
I hope this clears things up, if not I am available if you have any questions about it.

commented

Well I guess I can at least reopen this issue so that people see this if they are interested in adding such support.

commented

Was this added in Slimefun or why did you close this?

commented

I made plugin for fix this. But I currently removed the Slimefun4 plugin from my server, because cargo systems caused big lags.

commented

Is the plugin available? If so it would be good to link it here for others that search it. Otherwise the issue should stay open until a solution is available.