ChestShop (iConomyChestShop)

ChestShop (iConomyChestShop)

6M Downloads

Add Admin Shop name bypass

Krakenied opened this issue ยท 3 comments

commented

Related to f68a320

Players can't use admin shop named "Admin Shop"

commented

Closing as there was no further response and admin shops cork fine in testing.

commented

if (ChestShopSign.isAdminShop(name) || !USERNAME_PATTERN.matcher(name).matches()) {

It should be (!ChestShopSign.isAdminShop(name) && !USERNAME_PATTERN.matcher(name).matches())

commented

As far as I can tell admin shops work just fine? Please provide information on what bug you are experiencing/how to reproduce it.

Also that check was not really modified in the mentioned commit (only thing changed was that the player name pattern is now configurable) and it prevents players that try to abuse the plugin by using the same username as the admin shop is set to. If that was changed to what you suggest that prevention would no longer work.