Updating Item Metadata database to data version 3578 - Errors
andrewkm opened this issue · 6 comments
What is happening?
Did a test run for 1.20.2 to check out the damage on various plugins, lo and behold, ChestShop go nuts lol.
https://gist.githubusercontent.com/andrewkm/97d01a23d35315eb9bde317a5d2f7e2b/raw/031072bc925e34dbc2cf960ea0028c417382f3b3/gistfile1.txt
Any ideas what could be happening here?
What did you expect to happen?
Something more sane lol.
Plugin Version
Compiled against 53aa75d
Plugin Config
On Request.
Server Version
Paper 1.20.2 Build 207
Server Log
On Request.
What other plugins are you running?
On Request.
Agreements
- I have checked if there are already similar issues open.
- I am running the latest development version available from https://ci.minebench.de/job/ChestShop-3/.
- The version has support for this type of issue.
- I have provided all requested information and agree to the terms of the project's license
Additional context
On Request.
Getting a few other errors in console as well:
https://pastebin.com/raw/diV4fAna
https://pastebin.com/raw/WTxX90ct
You seem to have player skulls which are now considered invalid. Not sure if that is actually the case or just a bug in the server but realistically nothing ChestShop can do about and errors on item upgrades are kinda expected. Either re-create the the affected items or wait until there is a fix in the server (if that ever happens)
Getting a few other errors in console as well:
https://pastebin.com/raw/diV4fAna https://pastebin.com/raw/WTxX90ct
Different issue which should be in a different ticket and is happening due to an SQLite driver update removing functionality without proper deprecation. Unfortunately the library used to access the databese has no fix for that yet. md might downgrade the driver though until it's clear that the driver continues to use that breaking behaviour so we will see. Otherwise I will have to find a workaround once 1.20.2 is considered stable.
Regarding player skulls, are these skulls found inside of chest-shop chests? Can I safely ignore these and simply tell players to remake their chest shops if they are experiencing issues with skulls inside them?
Regarding SQLite, I believe md_5 reverted it via https://hub.spigotmc.org/jira/projects/SPIGOT/issues/SPIGOT-7491 now, so it should be fixed, will test shortly.
Yeah, I discussed it with md to revert that until libraries had time to update and it was clear that the change was there to stick. We will most likely update that with 1.21.
As for the skulls issue: Yes, they would basically need to recreate the shops that rely on such skulls in order for the IDs still matching up with the item. Nothing else should break due to that. I suspect that there is an actual bug with skulls though which could be fixed so if you can wait maybe do so until that is potentially fixed.
Can confirm the SQLite thing is fixed.
And yup, will wait, this is all just on my 1.20.2 test clone, that isn't yet in production. :)
As for the skulls issue: Yes, they would basically need to recreate the shops that rely on such skulls in order for the IDs still matching up with the item. Nothing else should break due to that. I suspect that there is an actual bug with skulls though which could be fixed so if you can wait maybe do so until that is potentially fixed.
So decided to actually go ahead and run my update just moments ago.
Weirdly enough I didn't see the skull errors anymore.
Either something updated in Paper, or perhaps it was our HeadDatabase update but who knows.
I'll assume all is functional as it should be now and close out the ticket. :)