CommandHelper

CommandHelper

46.5k Downloads

Core error when given invalid enchantment in ObjectGenerator.item(construct, t)

LadyCailinBot opened this issue ยท 4 comments

commented

CMDHELPER-3114 - Reported by PseudoKnight

Needs to check if etype is null after StaticLayer.GetEnchantmentByName(setype). I can address this after the exception commits.

commented

Comment by LadyCailin

Feel free to go ahead and submit a PR to the trycatch branch, and I will go ahead and pull it into that branch.

commented

Comment by PseudoKnight

Good idea. I probably should have done that with my other PR.

commented

Comment by PseudoKnight

Actually, I can still do that if you want. They can still be merged.

commented

Comment by LadyCailin

Yeah, go for it.