Support for 1.9
LadyCailinBot opened this issue · 5 comments
CMDHELPER-3124 - Reported by TheChampTF
[00:20:01] [Server thread/INFO]: [CommandHelper] Enabling CommandHelper v3.3.2-SNAPSHOT.3072-
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for ICE_PLAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MUSHROOM_SHORE. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for BEACH. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for SMALL_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for COLD_TAIGA. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for COLD_TAIGA_HILLS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MEGA_TAIGA. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MEGA_TAIGA_HILLS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for EXTREME_HILLS_PLUS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for SAVANNA_PLATEAU. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MESA_PLATEAU_FOREST. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MESA_PLATEAU. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for SUNFLOWER_PLAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for DESERT_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for FLOWER_FOREST. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for TAIGA_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for ICE_PLAINS_SPIKES. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for JUNGLE_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for JUNGLE_EDGE_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for COLD_TAIGA_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for SAVANNA_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for SAVANNA_PLATEAU_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MESA_BRYCE. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MESA_PLATEAU_FOREST_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MESA_PLATEAU_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for BIRCH_FOREST_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for BIRCH_FOREST_HILLS_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for ROOFED_FOREST_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MEGA_SPRUCE_TAIGA. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for EXTREME_HILLS_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for EXTREME_HILLS_PLUS_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for SWAMPLAND_MOUNTAINS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/ERROR]: �[31m[CommandHelper][ERROR][RUNTIME] Could not find a matching biome type for MEGA_SPRUCE_TAIGA_HILLS. This is an error, please report this to the bug tracker.�[m
[00:20:04] [Server thread/INFO]: CHVault 2.1.0 loaded.
[00:20:04] [Server thread/INFO]: SKCompat 2.1.0 loaded.
[00:20:04] [Server thread/INFO]: �[33m[CommandHelper]: MethodScript files processed�[m
[00:20:05] [Server thread/INFO]: �[33m[CommandHelper]: 91 alias(es) defined.�[m
[00:20:05] [Server thread/INFO]: [CommandHelper] CommandHelper 3.3.2-SNAPSHOT.3072- enabled
Comment by PseudoKnight
By the way, those are soft-errors. They should not impact your server unless you're using biomes somewhere. Sound ENUM changes and entity additions are probably more impactful to most servers.
Comment by PseudoKnight
Okay, PR'd most of it. jb-aero is doing the sound ENUMs.
Also, I noticed shoot_projectile does not launch the projectile anymore. This appears to be an issue on the server end, I think, but if it's a functional change and not a bug then we may need to compensate.
Comment by PseudoKnight
Most of this is done, now. We're still working on the sounds, but hopefully that'll be done by tomorrow.
Comment by PseudoKnight
I mapped the sound list to the new sound list. So that leaves a couple things:
Non-custom potion identification (spigot issue after 1.9 stopped using data values, currently out of my hands).
Interact events with off_hand are tricky, but might just have to be handled in scripts. The one thing I could do is return the hand (main or off hand) or slot (null or -106) used in the event. It'd make checking the item meta slightly easier. Right now I suggest just checking if the item used matches the item in hand, like so:
if(@event['item'] == pinfo(6)) {
// it's the main hand
@item = pinv(player(), null);
}
Is there anything else critical?