CommandHelper

CommandHelper

46.5k Downloads

[Feature request] colorize() to support hex colors

malonnnn opened this issue ยท 11 comments

commented

Would love to be able to do colorize('#87CEEBFlight &8Master')

commented

Appears that colorize(&#11223344) does work, but is not documented. That reforms the feature request to updating the colorize() documentation.

afbeelding

commented

The issue I'm having...

from a YML file, I have:

niceName: '&#FF00BBTest &1T&2e&3s&4t &#888888Test'

Then I read it in:

@char = read('./rpgClasses/'.@class)
@char = yml_decode(@char)

Then I print it:

ptellraw(@player, array(array(text: colorize(@char['niceName']))))

But it looks like:

https://i.imgur.com/1AI5GY2.png

The first word is a completely wrong color (looks like AQUA), and the 3rd word looks more like DARK_GRAY on my screenshot, and more like GRAY on yours. The hex colors are becoming the "standard" minecraft/terminal colors for me

commented

Oh, that's because you're using ptellraw(), which doesn't really support hex colors in the text value. (it seems to be using the last color code from the hex code, in this case: 'B') Use text component colors there instead.

commented

e.g. ptellraw(@player, array(array(color: '#FF00BB', text: 'Test')))

commented

What about trying to do multiple fancy color codes?

&#FF0000T&#BB0000e&#880000s&#330000t

I would still like to be able to easily do that

edit: oh wait, are you saying i should reopen this as a feature request to ptellraw?

commented

Multiple colors would require multiple text components.

ptellraw(@player, array(array(color: '#FF0000', text: 'T'), array(color: '#BB0000, text: 'e'), array(color: '#880000', text: 's'), array(color: '#330000', text: 't')))

This is just the json text format mojang uses. https://minecraft.fandom.com/wiki/Raw_JSON_text_format

commented

So are you saying I can't have a feature request to simplify this process?

Like how would I store a complicated colored name in a yaml file? I mean since ptellraw supports standard color codes already, I feel it should also support hex.

commented

It's complicated. You're using ptellraw(), which expects a specific vanilla format. The hex code format was never vanilla to begin with. So while the client can still handle the old color codes, the hex format is not supported. It only works with msg() because Spigot converts hex color codes to the json format before sending it to the client. I wrote some rough code on my server to approximately convert to mojang json text format, but an alternative some people are using is minimessage() in CHPaper. It's more 1:1 with the json format. https://docs.advntr.dev/minimessage/format.html

commented

Oh wow okay, I'm using CHPaper already and I see that minimessage() is supported there... would that more or less be able to fully replace ptellraw() for me?

commented

Yes. It supports all the most common features that you'd likely use. There's pros and cons to each approach, but I think minimessage would fit your use case quite well, if you like the format.

commented

We should still update the docs for colorize to indicate that they support hex colors.