CommandHelper

CommandHelper

46.5k Downloads

Crash on transient file persistance

LadyCailinBot opened this issue ยท 3 comments

commented

CMDHELPER-2818 - Reported by CyaNox

When running the /testpers command a error occurs on transient yml, ini and json. All others seem to be fine however I've not tested with larger sample sets so this may actually also occur with the other file storage persistence networks.

The error usually occurs with the larger sample sets though I've seen ini fail considerably quicker than the other two.

http://paste.thezomg.com/11862/84398882/

commented

Comment by LadyCailin

I am able to duplicate this using the test code.

commented

Comment by LadyCailin

It appears this is an issue with timings. Reads and writes aren't happening in the order they are supposed to. I've rewritten the ReadWriteConnection code that handled that, and it appears to be working now. I'm running some final tests, and then I'll commit, but this should be fixed in the next build.

commented

Comment by LadyCailin

Btw, here are the completed results:

Now profiling with 10 values:
  ini took 289 ms
  mem took 3 ms
  sqlite took 208 ms
  json took 55 ms
  ser took 129 ms
  yml took 357 ms
  tini took 5471 ms
  tmem took 2 ms
  tsqlite took 139 ms
  tjson took 46 ms
  tser took 28 ms
  tyml took 332 ms
Now profiling with 100 values:
  ini took 20 ms
  mem took 17 ms
  sqlite took 315 ms
  json took 16 ms
  ser took 18 ms
  yml took 22 ms
  tini took 54848 ms
  tmem took 10 ms
  tsqlite took 1266 ms
  tjson took 732 ms
  tser took 13 ms
  tyml took 1305 ms
Now profiling with 1000 values:
(t)ini skipped
  mem took 66 ms
  sqlite took 6357 ms
  json took 88 ms
  ser took 85 ms
  yml took 121 ms
(t)ini skipped
  tmem took 54 ms
  tsqlite took 2220 ms
  tjson took 4137 ms
  tser took 53 ms
  tyml took 12974 ms
Now profiling with 5000 values:
(t)ini skipped
  mem took 130 ms
  sqlite took 28212 ms
  json took 332 ms
  ser took 140 ms
  yml took 408 ms
(t)ini skipped
  tmem took 113 ms
  tsqlite took 20669 ms
  tjson took 72293 ms
  tser took 259 ms
  tyml took 264705 ms