CommandHelper

CommandHelper

46.5k Downloads

Play_note() works incorrectly.

LadyCailinBot opened this issue · 2 comments

commented

CMDHELPER-2910 - Reported by Алексей.Положенцев

/note $ = play_note(PIANO, array(octave: 1, tone: $))

Tried using in-game "/note A", "/note C", "/note D" and so on.
In all cases it was playing the same note.
Only "F#" in "octave:0" gives different result.

commented

Comment by PseudoKnight

To be specific, it increments octaves instead of pitch when you go to the next note. eg. F# is F#0; G is F#1; G# if F#2; everything else is F#2. However, looking at the code, there's nothing to suggest that this is a CH issue. I believe the last time there were issues with play_note it was bukkit, but I'm not that interested in looking at that code at the moment. But play_note always seems to have issues, which is why I use play_sound.

commented

Comment by EntityReborn

This appears to be a bukkit bug, as I've traced it up to the point where the data is handed to Bukkit, and everything looks to be in order. Won't fix.