CoreProtect

CoreProtect

1M Downloads

Core Inspect on LOWEST priority

JHarris12345 opened this issue · 10 comments

commented

I think the /co i for the armor stand / item frame lookups should be on the LOWEST priority instead of MONITOR. Other plugins that do things on the PlayerInteractEvent etc are going about their business ahead of CoreProtect which prevents look ups (say you're trying to look up player interactions on an armor stand but the player doesn't have permission to modify them)

commented

it being on monitor is the point, highest priority meaning the event is called last. This means plugins can do stuff related to the events it listens to such as cancel, modify etc before CoreProtect logs it

commented

CoreProtect won’t log things if the event was cancelled

commented

You haven't understood this at all. This isn't about logging. It's about looking up. If I try to use /co i to view transaction on an armor stand, it gets cancelled by the claiming plugin before core protect looks it up

commented

@Skullians view this vide. See how I can't look up armor stand transactions because the lookup is on the same priority as the log (MONITOR). The lookup needs to be in a different listener and on LOWEST (just like player interact lookups are)

2024-10-31.11-37-58.mp4
commented

OH you mean the inspect feature

commented

Yah that's what I said in the original message and the title xD

commented

Right, apologies, didn’t read your message properly.
In all honesty if you have co perms you should also have permission to bypass claims, but up to you.
Will wait for Intelli to see this (@Intelli), otherwise you’ll either have to wait, fork the code and change the priority yourself, or bypass claims

commented

I give my players lookup perms so definitely can't do that

commented

Huh… interesting

commented

Then yeah all you can do is fork the code or wait