CraftBook 3

CraftBook 3

139k Downloads

Recipe using Depreciated Method

LadyCailinBot opened this issue ยท 5 comments

commented

CRAFTBOOK-3360 - Reported by Omanoctoa

I'm getting excessive start-up spam for some reason, and I haven't found anyone else getting this issue. It appears to stem from this:

[Server] INFO [04:15:16 WARN]: java.lang.Throwable: Warning: A plugin is creating a recipe using a Deprecated method. This will cause you to receive warnings stating 'Tried to load unrecognized recipe: bukkit:'. Please ask the author to give their recipe a static key using NamespacedKey.

HEre's the full report:
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at net.minecraft.server.v1_12_R1.MinecraftServer.l(MinecraftServer.java:403)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at net.minecraft.server.v1_12_R1.MinecraftServer.t(MinecraftServer.java:442)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugins(CraftServer.java:344)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugin(CraftServer.java:395)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:316)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at com.sk89q.craftbook.bukkit.CraftBookPlugin.onEnable(CraftBookPlugin.java:341)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at com.sk89q.craftbook.bukkit.CraftBookPlugin.setupCraftBook(CraftBookPlugin.java:478)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at com.sk89q.craftbook.mechanics.crafting.CustomCrafting.enable(CustomCrafting.java:47)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at com.sk89q.craftbook.mechanics.crafting.CustomCrafting.addRecipe(CustomCrafting.java:74)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at org.bukkit.inventory.ShapedRecipe.(ShapedRecipe.java:26)
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: java.lang.Throwable: Warning: A plugin is creating a recipe using a Deprecated method. This will cause you to receive warnings stating 'Tried to load unrecognized recipe: bukkit:'. Please ask the author to give their recipe a static key using NamespacedKey.
28.05 04:15:16 [Server] INFO [04:15:16 WARN]: at java.lang.Thread.run(Thread.java:745)

I'm using Spigot 1.12.2 on a week-old server. I've used Craftbook for years and I'm using the latest dev release (or whatever the latest CB release was last Tuesday).

commented

Comment by me4502

Are you sure you're using the latest version? The method it's talking about hasn't been used by CraftBook for nearly a year now.

commented

Comment by Omanoctoa

As of a week ago, yes. Unless... ugh. I copied the recipes from the old crafting-recipes.yml to the new one. I had a look at the default crafting-recipes.yml and the indentation is different along with all lowercase names. Are you using minecraft item_names now or still the old ones?

Here's an example from my current crafting-recipes.yml

    craftedTimedBomb:
        type: shapeless
        ingredients:
            'WATCH ': 1
            'SLIME_BALL ': 1
            'TNT ': 1
        results:
            'SLIME_BALL;DURABILITY:10|&2Timed Bomb|&7Range I ': 1
        permission-node: perks.survival

Should it look like this, then?

  craftedtimedbomb:
    type: shapeless
    ingredients:
      'clock': 1
      'slime_ball': 1
      'tnt': 1
    results:
      'slime_ball;DURABILITY:10|&2Timed Bomb|&7Range I ': 1
    permission-node: perks.survival

I've create 2 recipes since last week and I've noticed it's still using the old setup for those 2 items (unless because I copied the old recipes in, it's creating new ones with the same format). Let me try something....gonna remove the recipes yml and generate a new one, and create a recipe in-game. See what it does...

Alright it generated a new crafting-recipes.yml and threw the same errors. The recipe syntax looks like it should using the new layout and such, identical to what it shows on the Craftbook wiki. Just to certain, I'm downloading and using the latest update now and will reply again after regenerating crafting-recipes.yml again.

commented

Comment by me4502

Could you please run /cb about and tell me what it outputs? It has nothing to do with the syntax, it's talking about using a Spigot method that's old, however CraftBook hasn't touched that since late June 2017.

commented

Comment by Omanoctoa

I was definitely using an old release, it showed as Craftbook 3.9 Snapshot, but the 3 newest Craftbook release (snapshots 4413, 4414 and 4416) won't load for me at all. Nothing in console that I can see, but HostHorde limits the Console output so I might just be missing it. Once I get one to load I'll try that out. I'm using the bukkit.org 3.9u22 release now, instead of the snapshots. That one shows as 3.9 instead, and is what I used last I think. Different file name though so maybe not...

This one works and outputs Craftbook 3.9u22 when I use /cb about. I have no idea what I was using, but this one generates no console errors so I'm gonna run with it.

commented

Comment by Omanoctoa

I just copied my old recipe file in, after changing all the custom recipe names to lowercase, and it loaded without an issue. So weird...