CraftBook 3

CraftBook 3

139k Downloads

hidden switch bypasses lock

LadyCailinBot opened this issue · 5 comments

commented

CRAFTBOOK-3449 - Reported by andrewkm

Recently got this report from one of our users:
Using: 3.10.1-Dev-#4539


Brief Description: Blocks adjacent to a hidden switch bypass the lock on said switch

Instructions: Create a hidden switch with blocks on all sides of it. U,D,L,R,Front
Lock the switch sign
the block the switch is on responds normally "locked by blah blah blah" message when used.
All other blocks bypass the entirely

How many times did you recreate this?: 4

Result: switch works for anyone who knows where to hit

Expected Result: Switch only works for those on the lock list.

commented

Comment by me4502

I don't really understand this issue? You have to right click the block the sign is on for it to trigger?

commented

Comment by andrewkm

Here is a further explanation by the user who reported this:

"here is the best I can do video wise. what I mean is this
a hidden switch is a sign attached to a block. (given)
if you lock it the block it is attached to is also locked (given)
any bordering blocks touching the sign directly will also activate the switch, so in front of, above, below, left and right of the sign...not the block it's attached to (not so clear by the plug in but easily discovered)
the problem is the bordering blocks do not respect the lock when used only the block the sign is directly attached to respects the lock."

Videos:
https://drive.google.com/file/d/1yC5LlcmptSw4rFrkz9bRFeJ-wkNpA8s4/view
https://drive.google.com/file/d/1yC5LlcmptSw4rFrkz9bRFeJ-wkNpA8s4/view

commented

Comment by me4502

This appears to have been caused by both a Spigot and CraftBook bug. The CraftBook bug being even allowing that block to hit the mechanic, and the Spigot one being the item being seen as invalid for that event.

I've given up on getting Spigot bugs fixed, so I've just fixed the CraftBook side.

commented

Comment by andrewkm

Latest response by the user:

So... It no longer allows the edges of the sign to activate the sign only the block it was placed on, and that block does respect the locks.
Would have loved to see the edge blocks added to respect the locking structure, but you get what you get.

commented

Comment by me4502

Those blocks weren’t supposed to be able to trigger it, it’s only due to a recent spigot issue that they even were