Unusual animal size-variance on Paper server
sverinn opened this issue · 5 comments
CraftBook Version
5.0.0-SNAPSHOT+4863-9cb04b6
Platform Version
Paper version 1.21.1-16-master@bf5852a (2024-08-16T07:29:16Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
Confirmations
- I am using the most recent Minecraft release.
- I am using a version of WorldEdit compatible with my Minecraft version.
- I am using a version of CraftBook compatible with my Minecraft version.
- I am using the latest or recommended version of my platform software.
- I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
- I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)
Bug Description
Animals suddenly became gigantic or miniature - possibly because of animal scale variance applied by CraftBook5 retroactively/incorrectly?
Expected Behavior
Normal-sized animals with scale variance
Reproduction Steps
- Start a paper server and generate a world
- Stop the server
- Add CraftBook5 plugin
- Start the server and let it run for some time
- Animals spawned naturally now occasionally have scale from very small (<0.25x of original) to very large (>2.5x of original).
Anything Else?
No response
# CraftBook BetterAI Configuration
# -- Generated for version: 5.0.0-SNAPSHOT
#
# More information about this mechanic is available at...
# https://craftbook.enginehub.org/en/5.0.0/mechanics/better_ai/
#
# NOTE! Make sure to enable this in the config.yml file if you wish to use it.
# The list of entities to enable the enhanced vision AI mechanic for.
enhanced-vision-enabled:
- minecraft:zombie
- minecraft:drowned
- minecraft:husk
- minecraft:zombified_piglin
# The list of entities to enable the critical bow AI mechanic for.
critical-bow-enabled:
- minecraft:skeleton
# The list of entities to enable the attack passive AI mechanic for.
attack-passive-enabled:
- minecraft:zombie
- minecraft:drowned
- minecraft:husk
# The list of entities to enable the flee from weapons AI mechanic for.
flee-from-weapons:
- minecraft:chicken
- minecraft:pig
- minecraft:cow
- minecraft:mooshroom
- minecraft:sheep
# Whether hostile mobs will ignore passive entities that are mounted by a hostile entity.
attack-passive-ignore-hostile-mounts: true
# The list of entities to enable the size variance AI mechanic for.
size-variance:
- minecraft:chicken
- minecraft:pig
- minecraft:cow
- minecraft:mooshroom
- minecraft:sheep
# Whether size variance also applies when breeding entities together.
size-variance-allow-breeding: true
# The possible variability from default size to apply to the entities.
size-variance-variability: 0.2
# The possible variability from the bred size to apply while breeding entities.
size-variance-breeding-variability: 0.1
Also, checking entity data revealed this:
Modifiers go on for about 100 lines or so
It seems that the older the entity is, the more repeated modifiers there are. For an entity 37500 ticks old there are 11 modifiers, an entity 925000 ticks old has 40-50 of them. Although, I'm not sure there is a correlation since I've been able to find 100000 ticks old entities with hundreds of modifiers.
I can 100% confirm this is CraftBook related since only entities listed for variance in config are affected.
The modifiers in your screenshot are not the ones added by CraftBook, it uses a size_variance and size_variance_breeding tag, such as can be seen in this video- https://x.com/the_me4502/status/1800491075884478902?s=46&t=9fkuzVwR2af-no0wwGig9g
if the tag is initially being added by CraftBook, then something else is merging that data into the generic scale tag and removing CraftBook’s tag- hence why it’d be getting added multiple times