CraftBook 3

CraftBook 3

139k Downloads

NPE - clickedPosition null on PlayerInteractEvent

andrewkm opened this issue ยท 8 comments

commented

CraftBook Version

CraftBook5 v5.0.0-SNAPSHOT+4879-d72d724

Platform Version

Paper 1.21.4-34-main@d568e17

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using a version of CraftBook compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

Bug Description

Errors in console:
https://pastebin.com/raw/uVCp2pBD

Expected Behavior

No errors.

Reproduction Steps

Unsure at this time.

Anything Else?

No response

commented

does this always happen? i wonder if Paper broke the API while doing the hard fork refactors

commented

Caught it a few times, seems to have started after hard fork.
EDIT: Seems to be happening quite often lately tbh.

commented

@me4502
Looks like we're getting this error every time any sign or hanging sign is left-clicked. It doesn't have to be an active Craftbook5 mechanic sign either. It happens with any placed sign.

commented

this is something that must be fixed within Paper itself, the error is not happening within CraftBook code and therefore isn't happening in a spot that we can actually check if it's null or not (we actually do check if the return value is null, but Paper now has a bug where if the value is null the getter itself errors)

commented

@me4502 Looks like we're getting this error every time any sign or hanging sign is left-clicked. It doesn't have to be an active Craftbook5 mechanic sign either. It happens with any placed sign.

Ah yeah, literally left clicking any sign causes this. xD
PS: Tested on 1.21.4 Build 40 to be up to date.

commented

this is the Paper commit that introduced the bug, PaperMC/Paper@083c083

you'd likely have to revert to a version prior to this until they've fixed it.

commented

a fix for this is now in Paper. closing the issue now.

commented

Confirmed fixed.