CraftBook 3

CraftBook 3

139k Downloads

Item Dspenser mc1201 spawns items at the wrong location

LadyCailinBot opened this issue ยท 6 comments

commented

CRAFTBOOK-2241 - Reported by fr34k_tk

CraftBook #1235 (it's not a new bug, happens with older versions too)
CraftBukkit 1.4.2_R0.2

Desctiption:
The spawned items from the mc1201 itemdispenser should be spawned above the first free block above the block the IC is attached to (like the old versions of CraftBook or FalseBook). Currently they spawn at the first free block above the sign, which makes it impossible to build an itemdispenser on top of each other.

commented

Comment by me4502

What version of CraftBook didn't have this bug?

commented

Comment by fr34k_tk

I'm sorry, but i really can't tell you which version, i switched to falsebook over a year ago but i could be wrong. It's not a new bug for sure.
FalseBook definitely handles the item-dispenser that way and the documentation says Craftbook should do the same.

commented

Comment by me4502

Hmm.. The issue is it's been like this for so long that many people have probably made use of it that way.

commented

Comment by fr34k_tk

I think most people don't care because they don't place ICs in a compact way. Most people which use this IC wouldn't even notice the change or why am i the first one mentioning that the documentation does not match with the behavior of the IC ingame.

It just makes much more sense, when the items spawn above the block the IC is attached to. All the other ICs like MC1205 SetBlockAbove or MC1207 FlexibleSetBlock are using the block the IC is attached to as the origin for the different offsets.

Another point is, that it's generally more useful when all the ICs behave the same. Especially that IC worked that way since Craftbook for hmod and still does for FalseBook and CraftBook-Extra for Canary.

There are several setups on my server which are currently disabled (after switching from FalseBook) which make use of the ability to place one above each other. The wiring would be much bigger and much more complex to overcome that.
It's currently also not possible to hide item-dispensers if the floor is only two blocks thick.

If there weren't any downsides with the current implementation it would not be a big problem, but the IC is much more useful, when it behaves like it did before.

commented

Comment by me4502

This was done yesteday.

commented

Comment by fr34k_tk

Thank you very much for fixing it. Works without any problem now.
Keep up your work on that plugin.