CraftBook 3

CraftBook 3

139k Downloads

MC1201 Item Dispenser IC Issue

LadyCailinBot opened this issue ยท 18 comments

commented

CRAFTBOOK-2289 - Reported by Chris.Lafferty

Been having some issues getting the Item Dispenser IC to work again. It broke on our server a few updates ago, it would just spit an NPE error to the console (no longer have that particular error, sorry). Then I saw that there was an update (3.3.9 & r2) that specifically addressed issues with MC1201, so I installed r2 and gave it a shot.

Now since that update, when activating an MC1201, the user is booted from the server with an End Of Stream error in the client. The server console throws a disconnect.genericReason at this point.

When the user logs back in, the server console throws the following error and the chunk that the IC resides in is regenerated (!!):

http://pastebin.com/2GckfuWW

Our server is running Java x64 1.7.0_02, and I also tested with 1.7.0_09, both on Ubuntu. Both tests were done using the latest CraftBukkit Beta build, 1.4.5-R0.2.

On the server, we've got a bunch of other plugins, so I tried it with just the CraftBook jars and their dependencies (Vault, WorldEdit) on a separate server, all freshly-generated config files, seems to do the same thing. Here's the startup log of the stripped-down test server, from server-start, to creating a new MC1201, to executing it, and then logging back in:

http://pastebin.com/k2kyk0ba

Please let me know if any other information would be helpful and I'd be happy to furnish it. Or, just tell me I'm an idiot and point to where I went wrong if it's more of a PEBKAC problem. :)

commented

Comment by me4502

End of stream is purely client side and can't be caused by the server. I'll look into fixing the errors.

commented

Comment by Chris.Lafferty

Just figured I'd mention what I'm seeing from both ends of things; full-disclosure and all. Thanks for checking into it!

commented

Comment by me4502

Am I able to get a screenshot of the IC?

commented

Comment by Chris.Lafferty

Sorry it took so long, didn't get your message until just a few minutes before I had to leave for work: http://imgur.com/DYH9J

commented

Comment by MUDcraft

This is exactly the same behavior I've observed myself.
I've reproduced this with both builds noted including the WE tempfix jar for 1.4.5.

commented

Comment by me4502

The issue is, I can't see how this can remotely be linked to CraftBook. What other plugins do you have on your server?

commented

Comment by me4502

Also can you try it using an ID? Not a word?

commented

Comment by Chris.Lafferty

Like I said, I thought it might be some sort of plugin conflict as well, so I created a test server running WorldEdit (required by CraftBook), all four CraftBook.jar files, and Vault (IIRC, the server would balk if I didn't have it installed, but I'm not sure if it's a requirement or not.) So six plugins total, fresh worlds, fresh config files, etc. And I just tried it with the ItemID of 1, same insta-kick End of stream message, same error in console on the next login.

commented

Comment by me4502

Hmm... I'll test it on a test server to see if the same thing happens.

commented

Comment by me4502

After testing, I can not get the client to be kicked and the chunk to regen... But the IC does not appear to be functioning. I tested with WorldEdit and all 4 CraftBook jars installed.

commented

Comment by Chris.Lafferty

Very strange indeed. You hadn't mentioned anything about running Vault on your test server, so I removed it from mine, I'm still getting the same kick and chunk regen. MUDcraft and I must have something that you do not, or conversely, we're missing something that you have. What other variables are we looking at, OS? Java version? Architecture?

commented

Comment by me4502

OS = Windows 7 64 Bit,
Java = 1.7.0_6 or something like that
Bukkit = Latest Dev build.
CraftBook = Current Source (Not commited yet)

commented

Comment by Chris.Lafferty

So the current version of CraftBook (3.3.9r2) was built against a Dev version of Bukkit, not against the latest Beta build (which is the latest-compatible version according to BukkitDev)? I know next-to-squat about Java programming and Bukkit plugin development, so forgive me if I'm just talking out of my posterior, but that seems to me like it could definitely break things.

commented

Comment by me4502

3.3.9r2 was built against bukkit 1.4.5r0.2 beta. Not against a dev build. I am not using 3.3.9r2, I am using latest code version.

Edit: Actually, No IC's work for me.

commented

Comment by Chris.Lafferty

Is the latest code version on Jenkins? I'll test it out and see if that's the variable we're looking for.

commented

Comment by me4502

Yes, it is... Well it should be soon... It's build 1379

http://build.sk89q.com/job/CraftBook/

commented

Comment by me4502

Btw, I just fixed it in the next build.

Edit: By fixed, I mean the IC now works. I was unable to reproduce the crashing issue.

commented

Comment by Chris.Lafferty

Oh, nice, many thanks!

Edit: No biggie, the fix will trickle down eventually, with the next CraftBukkit RB or Beta. We'll just do without ICs until then, too many breaking changes in the current Dev builds for a production server, and not all plugins developers are as quick on the draw as you. But I appreciate you taking the time to check into it and fixing ICs upstream. :)