Permission test still ran onPlayerMove even though snow mechanic is disabled.

Question

Permission test still ran onPlayerMove even though snow mechanic is disabled.

LadyCailinBot opened this issue 12 years ago · 4 comments

LadyCailinBot commented 12 years ago

CRAFTBOOK-2343 - Reported by Cayorion

I am running CraftBook 1600-ac19eac with the following config:

...
snow:
enable: false
trample: true
place: true
realistic: false
high-piling: false
jump-trample: false
...

So I disabled snow completely?
Yet when I profile my server with 175 players online I see that com.sk89q.craftbook.mech.Snow.onPlayerMove() is eating 1% of my server thread CPU cause it's doing some permission checks.

Could perhaps the plugin be slightly recoded so these permission checks are not run at all?

LadyCailinBot · Answer 1 · 2013-01-05T03:14:22.000Z

Comment by me4502

You still have trample and place enabled. Also you need to restart the server when disabling them.

LadyCailinBot · Answer 2 · 2013-01-05T09:47:39.000Z

Comment by Cayorion

Shouldn't the enable flag toggle all snow stuff of?

LadyCailinBot · Answer 3 · 2013-01-05T10:17:09.000Z

Comment by me4502

No, enable toggles piling of snow, it used to be enable-piling, but someone has renamed it.

Edit: I just renamed it back.

LadyCailinBot · Answer 4 · 2013-01-05T15:05:57.000Z

Comment by Cayorion

Ah great. That should make it more clear and consistent with the other "enable" config options. Thanks.

Share to