CraftBook 3

CraftBook 3

139k Downloads

item meta and enchantments for ingredients possible bug (craftbook)

LadyCailinBot opened this issue ยท 22 comments

commented

CRAFTBOOK-2609 - Reported by zy2222

item meta values and enchantments dont seem to work for ingredients, for example if one of the ingredients is STONE_SWORD;DURABILITY:2;FIRE_ASPECT:1, a regular stone sword will still work in that slot, same goes for item name and lore.

commented

Comment by me4502

I have added enchant support also now.

commented

Comment by zy2222

what I mean is, defining meta/enchants for the ingredient doesnt stop the regular item from working in the recipe. if the ingredient defined is STONE_SWORD;DURABILITY:2;FIRE_ASPECT:1, then ANY stone sword will work. Dunno if this is intended or not but its still happening in latest dev build.

commented

Comment by me4502

What build is 'latest dev build'?

commented

Comment by zy2222

sorry, 2251

commented

Comment by me4502

Hmm.. So you are using 2251 and it still isn't working? Can you please do /cb report -p

commented
commented

Comment by me4502

Can you please pastebin the recipes file?

commented

Comment by zy2222

http://pastebin.com/HpyKgGvh

for the gswordfire recipe, any enchanted book can be used

commented

Comment by me4502

In the config, can you please enable debug mode.. Then add item-checks to debug flags?

Once thats done, please try to craft the recipe, and pastebin the console output.

commented

Comment by me4502

Actually, can you also add advanced-data to the debug flags as well?

commented

Comment by zy2222

http://pastebin.com/TE2aYEhW

1st crafted with regular enchanted book, 2nd crafted with correctly named enchanted book

commented

Comment by me4502

I am looking into this... It doesn't seem to be checking the ingredients.

commented

Comment by me4502

Can you please test build 2253?

commented

Comment by zy2222

issue still there

commented

Comment by me4502

Can you please do it with 'item-checks' and 'advanced-data' debug flags, then pastebin the output?

commented
commented

Comment by me4502

Hmm.. I am looking into this.

commented

Comment by me4502

Please test with the debug flags on 2254. Also, do Shapeless recipes with ingredients with data work?

commented

Comment by zy2222

shaped still bugged, shapeless seems to work

shaped: http://pastebin.com/gHPEqrB0

shapeless: http://pastebin.com/su0sjyur

commented

Comment by me4502

I believe I found the issue. Bukkit severely messes with recipes when created. I believe I have modified the methods in 2255 to accommodate for these messed up recipes.

commented

Comment by zy2222

looks good so far, ill update this ticket if I find anything else, Cheers!

commented

Comment by me4502

Okay, thanks :D
I am glad this is fixed now.