Add support for percusion in the midiplayer IC
LadyCailinBot opened this issue ยท 3 comments
CRAFTBOOK-2610 - Reported by tssge
Hello.
Percussion support for midisongs would be really nice.
https://github.com/sk89q/craftbook/blob/84ea36044b5763806dc288e97d6eecb781320a48/src/main/java/com/sk89q/craftbook/circuits/jinglenote/MidiJingleSequencer.java#L125
It seems to be commented out on the following line, or something. Doesn't seem like much work. The comment states though, that they sound like crap, so maybe you could introduce a new configuration variable for toggling percussion on/off?
Thanks in advance,
tssge
Comment by me4502
Yeah, I could add a configuration option to allow percussion in midis. But I must warn you it sounds incredibly bad.